Re: [PATCH 4/6] selftests/damon/drgn_dump_damon_status: dump probes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing dictionary mapping for DAMON_FILTER_TYPE_PGIDLE_UNSET causes a KeyError crash when dumping DAMON status.
--

commit 331c442077c25bd4d245acf2c04de56eaa44e0db
Author: SJ Park <sj@kernel.org>

selftests/damon/drgn_dump_damon_status: dump probes

This commit extends drgn_dump_damon_status.py to dump damon_ctx->probes. It is
intended to monitor in-kernel DAMON status changes when the user sets probes
via sysfs.

> diff --git a/tools/testing/selftests/damon/drgn_dump_damon_status.py b/tools/testing/selftests/damon/drgn_dump_damon_status.py
> --- a/tools/testing/selftests/damon/drgn_dump_damon_status.py
> +++ b/tools/testing/selftests/damon/drgn_dump_damon_status.py
> @@ -48,6 +48,37 @@ def attrs_to_dict(attrs):
>          ['max_nr_regions', int],
>          ])
>  
> +def filter_to_dict(damon_filter):
> +    filter_type_keyword = {
> +            0: 'anon',
> +            1: 'memcg',
> +            }
> +    dict_ = {
> +            'type': filter_type_keyword[int(damon_filter.type)],

[Severity: Medium]
Will filter_to_dict() crash with a KeyError if a user configures a DAMON probe
with a filter of type pgidle_unset via sysfs?

If damon_filter.type is assigned the value 2 (DAMON_FILTER_TYPE_PGIDLE_UNSET),
the filter_type_keyword dictionary does not have a mapping for it. This could
cause the Python diagnostic script to crash, preventing the user from
inspecting the internal DAMON state.

> +            'matching': bool(damon_filter.matching),
> +            'allow': bool(damon_filter.allow),
> +            }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902140313.85983-1-sj@kernel.org?part=4