From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 2/3] Revert "mm/damon/lru_sort: error out for >10000 active_mem_bp"
Date: Thu, 03 Sep 2026 01:15:03 +0000 [thread overview]
Message-ID: <20260903011503.7E78E1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903010722.94244-3-sj@kernel.org>
> This reverts commit 06befa61c427e74319781e6f35a364cfc32dbae8.
>
> The commit was made to avoid zero damos quota goal target value, because
> it can trigger division-by-zero. Now the core layer handles the corner
> case. It returns an error for any attempt setting the aero
> target_value. The corner case handling in DAMON_LRU_SORT is hence no
> more needed. Remove it.
>
> Note that this slightly changes the user behavior. It still disallows
> active_mem_bp of 10,002. But now it allows other >10,000 active_mem_bp
> values. Setting >10,000 active_mem_bp makes not much sense. But it
> doesn't cause critical problems such as memory leak or crash, either.
> Arguably that doesn't deserve additional code complexity. Just allow
> it.
>
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903010722.94244-1-sj@kernel.org?part=2
next prev parent reply other threads:[~2026-09-03 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 1:07 [PATCH 0/3] mm/damon: move zero damos quota target_value handling to the core layer SJ Park
2026-09-03 1:07 ` [PATCH 1/3] mm/damon/core: error damos_commit_quota_goal() for zero target_value SJ Park
2026-09-03 1:16 ` sashiko-bot
2026-09-03 1:07 ` [PATCH 2/3] Revert "mm/damon/lru_sort: error out for >10000 active_mem_bp" SJ Park
2026-09-03 1:15 ` sashiko-bot [this message]
2026-09-03 1:07 ` [PATCH 3/3] Revert "samples/damon/mtier: error out for zero quota goal target values" SJ Park
2026-09-03 1:15 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903011503.7E78E1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox