From: SJ Park <sj@kernel.org>
To: Kunwu Chan <kunwu.chan@gmail.com>
Cc: SJ Park <sj@kernel.org>, Kunwu Chan <kunwu.chan@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org,
Ravi Jonnalagadda <ravis.opensrc@gmail.com>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 3/4] mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit
Date: Thu, 3 Sep 2026 06:49:32 -0700 [thread overview]
Message-ID: <20260903134932.98268-1-sj@kernel.org> (raw)
In-Reply-To: <20260903084547.960584-1-kunwu.chan@linux.dev>
On Thu, 3 Sep 2026 16:45:45 +0800 Kunwu Chan <kunwu.chan@gmail.com> wrote:
> On Tue, 1 Sep 2026 17:27:22 -0700 SJ Park <sj@kernel.org> wrote:
[...]
> > This issue was discovered [1] by Sashiko.
> >
> > [1] https://lore.kkernel.org/20260827045035.94611-1-sj@kernel.org
>
> Hi SJ,
>
> The fix is consistent with the other node-based quota metrics. I also
> checked that damos_get_node_eligible_mem_bp() directly uses goal->nid
> when calculating the current value.
>
> One minor typo: the [1] has an extra k (kkernel should be kernel).
Nice catch, thank you Kunwu! Andrew, could you please fix this when you pick
this series up? Let me know if you prefer reposting the series with the fix.
>
> Reviewed-by: Kunwu Chan <kunwu.chan@gmail.com>
Appreciate all the reviews, Kunwu!
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-09-03 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 0:27 [PATCH 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms SJ Park
2026-09-02 0:27 ` [PATCH 1/4] mm/damon/tests/core-kunit: test committing psi goal to psi goal SJ Park
2026-09-02 0:34 ` sashiko-bot
2026-09-03 8:33 ` Kunwu Chan
2026-09-02 0:27 ` [PATCH 2/4] mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total SJ Park
2026-09-02 0:34 ` sashiko-bot
2026-09-03 9:23 ` Kunwu Chan
2026-09-02 0:27 ` [PATCH 3/4] mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit SJ Park
2026-09-02 0:39 ` sashiko-bot
2026-09-02 1:13 ` SJ Park
2026-09-02 1:14 ` SJ Park
2026-09-03 8:45 ` Kunwu Chan
2026-09-03 13:49 ` SJ Park [this message]
2026-09-02 0:27 ` [PATCH 4/4] mm/damon/sysfs: set next refresh jiffies per sysfs context SJ Park
2026-09-02 0:39 ` sashiko-bot
2026-09-03 10:01 ` Kunwu Chan
2026-09-02 1:16 ` [PATCH 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms SJ Park
2026-09-03 3:13 ` Lian Wang
2026-09-03 13:51 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903134932.98268-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@gmail.com \
--cc=kunwu.chan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ravis.opensrc@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox