DAMON development mailing list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Eva Kurchatova" <eva.kurchatova@virtuozzo.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH] selftests: damon: add script dir to sys.path for PYTHONSAFEPATH compatibility
Date: Tue, 08 Sep 2026 21:48:17 +0000	[thread overview]
Message-ID: <20260908214818.355E91F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908214238.2680324-1-eva.kurchatova@virtuozzo.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch claims to fix PYTHONSAFEPATH compatibility for all DAMON Python selftests, but misses 3 test scripts, leading to an incomplete fix and a commit message mismatch.
--

commit 3a3c43c4b8c811027e52bf0fa5b68c48216e86c4
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

selftests: damon: add script dir to sys.path for PYTHONSAFEPATH compatibility

This commit adds the script's directory to sys.path for several DAMON Python
selftests to fix ModuleNotFoundError issues when running under Python's safe
path mode. It claims to fix all 7 tests that import the _damon_sysfs helper
module.

>     This breaks all 7 DAMON Python selftests that import the _damon_sysfs
>     helper module located in the same directory:

[Severity: Medium]
Are there more than 7 tests affected by this? It looks like sysfs.py,
sysfs_refresh.py, and sysfs_no_op_commit_break.py in
tools/testing/selftests/damon/ also import _damon_sysfs but lack the
sys.path.append() workaround introduced in this commit.

If these tests are run with PYTHONSAFEPATH set in the environment or with -P
on the interpreter command line, will they continue to fail with a
ModuleNotFoundError?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908214238.2680324-1-eva.kurchatova@virtuozzo.com?part=1

  reply	other threads:[~2026-09-08 21:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 21:42 [PATCH] selftests: damon: add script dir to sys.path for PYTHONSAFEPATH compatibility Eva Kurchatova
2026-09-08 21:48 ` sashiko-bot [this message]
2026-09-09  0:24   ` SJ Park
2026-09-09  0:20 ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908214818.355E91F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox