DAMON development mailing list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 7.2.y] mm/damon/paddr: drop last same folio access check reuse optimization
Date: Wed, 09 Sep 2026 05:34:59 +0000	[thread overview]
Message-ID: <20260909053500.38D211F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260909053151.242944-1-sj@kernel.org>

> It can race when multiple kdamonds are being used.  The problem from the
> race is doubtful, but the gain from the optimization is also doubtful.
> Simply drop the optimization in favor of code simplicity.
> 
> The user impact is doubtfully trivial.  After all, this kind of
> interference can happen only by intentional user setup.  Even if it
> happens, it will be rare, and the consequence is degradation of the
> best-effort monitoring results.  No critical consequences like kernel
> panic or memory corruption happen.
> 
> The race was discovered [1] by Sashiko.
> 
> Link: https://lore.kernel.org/20260715031002.108504-5-sj@kernel.org
> Link: https://lore.kernel.org/20260621204050.10993-1-sj@kernel.org [1]
> Fixes: a28397beb55b ("mm/damon: implement primitives for physical address space monitoring")
> Signed-off-by: SJ Park <sj@kernel.org>
> Cc: <stable@vger.kernel.org> # 5.16.x
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> (cherry picked from commit f23f0aa62b2f32c2b12f95959fc4603ef81678b2)
> Signed-off-by: SJ Park <sj@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909053151.242944-1-sj@kernel.org?part=1


      reply	other threads:[~2026-09-09  5:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2026090851-hulk-tutor-8154@gregkh>
2026-09-09  5:31 ` [PATCH 7.2.y] mm/damon/paddr: drop last same folio access check reuse optimization SJ Park
2026-09-09  5:34   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909053500.38D211F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox