From: sashiko-bot@kernel.org
To: "Liew Rui Yan" <aethernet65535@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH] mm/damon/core: add short circuit for temporal-goal schemes in damos_adjust_quota()
Date: Sat, 12 Sep 2026 12:49:46 +0000 [thread overview]
Message-ID: <20260912124947.02AC11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260912124406.96535-1-aethernet65535@gmail.com>
> When using the temporal auto-tuning algorithm, the effective size quota
> becomes zero once the goal is [over-]achieved.
>
> In this situation, damos_adjust_quota() still calculates
> quota->min_score for it. However, this min_score will not be used in
> this window, because in damon_do_apply_schemes(), damos_quota_is_full()
> will always returns true, preventing the scheme from being applied to
> any region.
>
> Therefore, add a short circuit for temporal-goal algorithm schemes to
> early return from damos_adjust_quota() before calculating min_score.
>
> Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260912124406.96535-1-aethernet65535@gmail.com?part=1
next prev parent reply other threads:[~2026-09-12 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 12:43 [RFC PATCH] mm/damon/core: add short circuit for temporal-goal schemes in damos_adjust_quota() Liew Rui Yan
2026-09-12 12:49 ` sashiko-bot [this message]
2026-09-12 16:48 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912124947.02AC11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox