Re: [RFC PATCH 7/9] selftests/damon/sysfs_memcg_path_leak: fail only for real DAMON leak

[SJ Park <sj@kernel.org>]

On Sat, 12 Sep 2026 20:15:18 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] Use of the non-standard `--quiet` flag in `grep` can cause the test to silently mask real memory leaks on systems with strict POSIX grep implementations.
> - [Low] Typo in the warning message: 'apparenty' instead of 'apparently'.
> --
> 
> commit afc83fe4758b4c2e76cc3da97cb99e2a990b6b83
> Author: SJ Park <sj@kernel.org>
> 
> selftests/damon/sysfs_memcg_path_leak: fail only for real DAMON leak
> 
> The selftest can fail for any leak if it happens while the test is running.
> Remove the false positive test failures by further checking if the expected
> leaking function is called out on the report.
> 
> > diff --git a/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh b/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh
> > index 33a7ff43ed6cc..6c2d8bb3fe570 100755
> > --- a/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh
> > +++ b/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh
> > @@ -41,5 +41,12 @@ if [ "$kmemleak_report" = "" ]
> >  then
> >  	exit 0
> >  fi
> > +if ! echo "$kmemleak_report" | grep "memcg_path_store" --quiet
> 
> [Severity: Medium]
> Could the --quiet flag cause the test to accidentally mask real memory leaks?
> 
> If the test runs in an environment with a strict POSIX grep implementation
> that does not support the GNU extension --quiet, grep will fail with an
> unrecognized option error.
> 
> Because of the negated condition, a non-zero exit code from grep causes the
> script to evaluate to true, print a warning, and exit 0. Should the standard
> POSIX -q flag be used instead to ensure compatibility?

I believe kselftest runs on systems modern enough to have --quiet option.  Let
me know if I'm wrong.

> 
> > +then
> > +	echo "[WARN] memleak found; apparenty not from DAMON, though"
> 
> [Severity: Low]
> This isn't a bug, but there is a typo in the warning message (apparenty
> instead of apparently).

Good eyes, I will fix in the next spin.

> 
> > +	echo "$kmemleak_report"
> > +	exit 0
> > +fi
> > +
> >  echo "$kmemleak_report"
> >  exit 1
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260912200814.145612-1-sj@kernel.org?part=7


Thanks,
SJ