From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH v2 3/8] mm/damon/core: return an error from damos_commit_filter_arg()
Date: Sun, 13 Sep 2026 17:25:23 +0000 [thread overview]
Message-ID: <20260913172524.5BAF71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260913171706.103052-4-sj@kernel.org>
> damos_commit_filter_arg() is supposed to always succeed. It may not in
> future, for example, if the given filter is invalid. Prepare the case
> by modifying its signature to return an error when it failed. Also pipe
> the return value to its callers and let them handle the error.
>
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260913171706.103052-1-sj@kernel.org?part=3
next prev parent reply other threads:[~2026-09-13 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 17:16 [RFC PATCH v2 0/8] mm/damon: move damos filter range arguments validation to core SJ Park
2026-09-13 17:16 ` [RFC PATCH v2 1/8] mm/damon/sysfs-schemes: read sysfs_filter->addr_range only once SJ Park
2026-09-13 17:32 ` sashiko-bot
2026-09-13 17:16 ` [RFC PATCH v2 2/8] mm/damon/sysfs-schemes: read sysfs_filter->sz_range " SJ Park
2026-09-13 17:29 ` sashiko-bot
2026-09-13 17:17 ` [RFC PATCH v2 3/8] mm/damon/core: return an error from damos_commit_filter_arg() SJ Park
2026-09-13 17:25 ` sashiko-bot [this message]
2026-09-13 17:17 ` [RFC PATCH v2 4/8] mm/damon/core: disallow max < min damos filter range arguments commit SJ Park
2026-09-13 17:26 ` sashiko-bot
2026-09-13 17:17 ` [RFC PATCH v2 5/8] mm/damon/sysfs-schemes: drop centralized filter range arg validations SJ Park
2026-09-13 17:25 ` sashiko-bot
2026-09-13 17:17 ` [RFC PATCH v2 6/8] mm/damon/sysfs-schemes: use switch-case in add_scheme_filters() SJ Park
2026-09-13 17:22 ` sashiko-bot
2026-09-13 17:17 ` [RFC PATCH v2 7/8] mm/damon/core-kunit: extend damos_commit_filter_for() for wrong input SJ Park
2026-09-13 17:22 ` sashiko-bot
2026-09-13 17:17 ` [RFC PATCH v2 8/8] mm/damon/core-kunit: test invalid damos filter commits SJ Park
2026-09-13 17:28 ` sashiko-bot
2026-09-13 17:50 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913172524.5BAF71F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox