From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 4/8] mm/damon/core: disallow max < min damos filter range arguments commit
Date: Mon, 14 Sep 2026 15:13:29 +0000 [thread overview]
Message-ID: <20260914151330.0DCBC1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260914142327.92510-5-sj@kernel.org>
> damos_commit_filter_arg() receives range arguments for a few types of
> DAMOS filters. It allows any range including max < min range. It is
> fine for the logic, but makes no sense to support it. Actually DAMON
> sysfs interface is doing the validation on its own. To avoid duplicated
> validations in multiple DAMON API callers, it would be better to do the
> validation in the core layer. Add a validation of the given range.
>
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914142327.92510-1-sj@kernel.org?part=4
next prev parent reply other threads:[~2026-09-14 15:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 14:23 [PATCH 0/8] mm/damon: move damos filter range arguments validation to core SJ Park
2026-09-14 14:23 ` [PATCH 1/8] mm/damon/sysfs-schemes: read sysfs_filter->addr_range only once SJ Park
2026-09-14 14:44 ` sashiko-bot
2026-09-14 14:23 ` [PATCH 2/8] mm/damon/sysfs-schemes: read sysfs_filter->sz_range " SJ Park
2026-09-14 14:57 ` sashiko-bot
2026-09-14 14:23 ` [PATCH 3/8] mm/damon/core: return an error from damos_commit_filter_arg() SJ Park
2026-09-14 15:04 ` sashiko-bot
2026-09-14 14:23 ` [PATCH 4/8] mm/damon/core: disallow max < min damos filter range arguments commit SJ Park
2026-09-14 15:13 ` sashiko-bot [this message]
2026-09-14 14:23 ` [PATCH 5/8] mm/damon/sysfs-schemes: drop centralized filter range arg validations SJ Park
2026-09-14 15:26 ` sashiko-bot
2026-09-14 14:23 ` [PATCH 6/8] mm/damon/sysfs-schemes: use switch-case in add_scheme_filters() SJ Park
2026-09-14 15:31 ` sashiko-bot
2026-09-14 14:23 ` [PATCH 7/8] mm/damon/core-kunit: extend damos_commit_filter_for() for wrong input SJ Park
2026-09-14 15:36 ` sashiko-bot
2026-09-14 14:23 ` [PATCH 8/8] mm/damon/core-kunit: test invalid damos filter commits SJ Park
2026-09-14 15:44 ` sashiko-bot
2026-09-14 23:42 ` SJ Park
2026-09-14 23:43 ` [PATCH 0/8] mm/damon: move damos filter range arguments validation to core SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914151330.0DCBC1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox