From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 7/8] Docs/admin-guide/mm/damon/usage: update for hugepage_size
Date: Tue, 15 Sep 2026 14:39:48 +0000 [thread overview]
Message-ID: <20260915143949.475871F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915143359.91472-8-sj@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] doc: grammatical error in damon usage documentation
--
commit f587d7d9920741b1ef2aaf02c04d27dcea002f5e
Author: SJ Park <sj@kernel.org>
Docs/admin-guide/mm/damon/usage: update for hugepage_size
Update DAMON usage document for the newly added hugepage_size data
attribute filter type.
> diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
> index d3e37400367bd..6b80bce5d678d 100644
> --- a/Documentation/admin-guide/mm/damon/usage.rst
> +++ b/Documentation/admin-guide/mm/damon/usage.rst
[ ... ]
> @@ -308,6 +308,8 @@ Writing a number (``N``) to the file creates the number of child directories
> named ``0`` to ``N-1``. Each directory represents each filter and works in a
> way similar to that for :ref:`DAMOS filter <sysfs_filters>`. When the filter
> ``type`` is ``memcg``, ``path`` file acts as ``memcg_path`` for :ref:`DAMOS
> +filter <sysfs_filters>`. When the filter ``type`` is ``hugepage_size``,
> +``min`` and ``max`` files acts as files of the same names for :ref:`DAMOS
[Severity: Low]
This isn't a bug, but should "acts" be "act" here since "files" is plural?
> filter <sysfs_filters>`.
>
> .. _sysfs_targets:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915143359.91472-1-sj@kernel.org?part=7
next prev parent reply other threads:[~2026-09-15 14:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:33 [PATCH 0/8] mm/damon: introduce hugepage_size probe filter SJ Park
2026-09-15 14:33 ` [PATCH 1/8] mm/damon/api: introduce DAMON_FILTER_TYPE_HUGEPAGE_SIZE SJ Park
2026-09-15 14:43 ` sashiko-bot
2026-09-15 14:33 ` [PATCH 2/8] mm/damon/core: commit hugepage_size type damon filter SJ Park
2026-09-15 14:44 ` sashiko-bot
2026-09-15 14:33 ` [PATCH 3/8] mm/damon/ops-common: support hugepage_size damon filter matching SJ Park
2026-09-15 14:47 ` sashiko-bot
2026-09-15 14:33 ` [PATCH 4/8] mm/damon/sysfs: add min,max files under probe filter directory SJ Park
2026-09-15 14:42 ` sashiko-bot
2026-09-15 14:33 ` [PATCH 5/8] mm/damon/sysfs: support hugepage_size probe filter SJ Park
2026-09-15 14:44 ` sashiko-bot
2026-09-15 14:33 ` [PATCH 6/8] Docs/mm/damon/design: update for " SJ Park
2026-09-15 14:36 ` sashiko-bot
2026-09-15 14:33 ` [PATCH 7/8] Docs/admin-guide/mm/damon/usage: update for hugepage_size SJ Park
2026-09-15 14:39 ` sashiko-bot [this message]
2026-09-15 14:53 ` SJ Park
2026-09-15 15:01 ` SJ Park
2026-09-15 14:33 ` [PATCH 8/8] Docs/ABI/damon: update for hugepage_size probe filter SJ Park
2026-09-15 14:41 ` sashiko-bot
2026-09-15 14:58 ` [PATCH 0/8] mm/damon: introduce " SJ Park
2026-09-15 23:39 ` Andrew Morton
2026-09-15 23:49 ` SJ Park
2026-09-16 5:57 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915143949.475871F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox