From: sashiko-bot@kernel.org
To: "Donggeun Yoo" <donggeunyoo.kernel@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v1 1/2] mm/damon/core: charge only the part of a region the filter left
Date: Thu, 17 Sep 2026 00:43:55 +0000 [thread overview]
Message-ID: <20260917004355.BE4CB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917003553.2465523-2-donggeunyoo.kernel@gmail.com>
> An address range DAMOS filter that partially overlaps a monitoring
> region splits the region at the filter boundary, so the scheme action is
> applied to only one side of it. damos_apply_scheme() reads the region
> size once on entry, before damos_core_filter_out() performs that split.
>
> The quota charge and the statistics update therefore account for the
> region as it was before the trim. schemes/<S>/stats/sz_tried counts
> memory the filter excluded, which Documentation/mm/damon/design.rst says
> is not counted as tried, and with quotas/bytes set the excluded part is
> charged against the budget, throttling the scheme to a fraction of what
> was configured.
>
> Re-read the region size after the core filters have run.
>
> Fixes: ab9bda001b68 ("mm/damon/core: introduce address range type damos filter")
> Cc: <stable@vger.kernel.org> # 6.6.x
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917003553.2465523-1-donggeunyoo.kernel@gmail.com?part=1
next prev parent reply other threads:[~2026-09-17 0:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 0:35 [PATCH v1 0/2] mm/damon/core: fix the size charged for a filter-trimmed region Donggeun Yoo
2026-09-17 0:35 ` [PATCH v1 1/2] mm/damon/core: charge only the part of a region the filter left Donggeun Yoo
2026-09-17 0:43 ` sashiko-bot [this message]
2026-09-17 1:24 ` SJ Park
2026-09-17 1:38 ` Donggeun Yoo
2026-09-17 0:35 ` [PATCH v1 2/2] mm/damon/tests/core-kunit: test the size charged for a filter-trimmed region Donggeun Yoo
2026-09-17 0:42 ` sashiko-bot
2026-09-17 1:26 ` SJ Park
2026-09-17 1:28 ` [PATCH v1 0/2] mm/damon/core: fix " SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917004355.BE4CB1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=donggeunyoo.kernel@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox