From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH v5 2/8] mm/damon/core: add complement argument to damos_new_quota_goal()
Date: Mon, 28 Sep 2026 09:42:58 +0000 [thread overview]
Message-ID: <20260928094259.551B51F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928093342.16584-3-sj@kernel.org>
> damos_quota_goal->complement needs to be manually set by each API
> callers. It is easy to make mistakes. Extend the quota goal
> constructor, damos_new_quota_goal() to receive and set the complement
> flag value. Also update all callers to use the new signature.
>
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928093342.16584-1-sj@kernel.org?part=2
next prev parent reply other threads:[~2026-09-28 9:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 9:33 [RFC PATCH v5 0/8] mm/damon: introduce damos quota goal target metric complement flag SJ Park
2026-09-28 9:33 ` [RFC PATCH v5 1/8] mm/damon/core: introduce damos_quota_goal->complement SJ Park
2026-09-28 9:44 ` sashiko-bot
2026-09-28 9:47 ` SJ Park
2026-09-28 9:33 ` [RFC PATCH v5 2/8] mm/damon/core: add complement argument to damos_new_quota_goal() SJ Park
2026-09-28 9:42 ` sashiko-bot [this message]
2026-09-28 9:33 ` [RFC PATCH v5 3/8] mm/damon/sysfs-schemes: support quota goal complement flag SJ Park
2026-09-28 9:40 ` sashiko-bot
2026-09-28 9:33 ` [RFC PATCH v5 4/8] mm/damon/tests/core-kunit: test quota_goal->complement commit SJ Park
2026-09-28 9:37 ` sashiko-bot
2026-09-28 9:33 ` [RFC PATCH v5 5/8] selftests/damon/sysfs.sh: test quota goal complement flag file SJ Park
2026-09-28 9:36 ` sashiko-bot
2026-09-28 9:33 ` [RFC PATCH v5 6/8] Docs/mm/damon/design: document damos quota goal complement flag SJ Park
2026-09-28 9:39 ` sashiko-bot
2026-09-28 9:33 ` [RFC PATCH v5 7/8] Docs/admin-guide/mm/damon/usage: update for quota goal complement file SJ Park
2026-09-28 9:38 ` sashiko-bot
2026-09-28 9:33 ` [RFC PATCH v5 8/8] Docs/ABI/damon: update for quota goal metric complement sysfs file SJ Park
2026-09-28 9:43 ` sashiko-bot
2026-09-28 9:49 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928094259.551B51F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox