DAMON development mailing list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 2/3] mm/damon: use damon_get_monitor_folio() for hugetlb entries
Date: Tue, 06 Oct 2026 06:58:43 +0000	[thread overview]
Message-ID: <20261006065843.DBB521F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006065209.41507-3-sj@kernel.org>

> From: Gregory Price <gourry@gourry.net>
> 
> Hugetlb folio acquisition is open-coded in three places:
>   - damon_hugetlb_mkold()
>   - damon_young_hugetlb_entry()
>   - damon_va_probe_hugetlb_entry()
> 
> DAMON already has damon_get_monitor_folio(), which paddr uses to
> get monitored LRU and hugetlb folios and to filter them through
> damon_folio_acceptable().  These paths bypass that check.
> 
> Use that helper in these paths too, so that DAMON acquires hugetlb
> folios and applies its acceptance policy in one place.
> 
> No functional change intended. All callers reach these paths with a
> present hugetlb PTE under the page table lock, so the folio is always
> a mapped hugetlb folio and the helper always returns it.
> 
> Cc: Gregory Price <gourry@gourry.net>
> Signed-off-by: Gregory Price (Meta) <gourry@gourry.net>
> Reviewed-by: SJ Park <sj@kernel.org>
> Signed-off-by: SJ Park <sj@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006065209.41507-1-sj@kernel.org?part=2


  reply	other threads:[~2026-10-06  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06  6:52 [PATCH 0/3] mm/damon: fix a minor bug, clean code, and add a test SJ Park
2026-10-06  6:52 ` [PATCH 1/3] mm/damon/ops-common: fix age_in_sec overflow on 32-bit SJ Park
2026-10-06  7:00   ` sashiko-bot
2026-10-06  6:52 ` [PATCH 2/3] mm/damon: use damon_get_monitor_folio() for hugetlb entries SJ Park
2026-10-06  6:58   ` sashiko-bot [this message]
2026-10-06  6:52 ` [PATCH 3/3] mm/damon/tests/core-kunit: add test for unconditionally skipping the last region SJ Park
2026-10-06  6:55   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006065843.DBB521F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox