From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F2C1A0BD0 for ; Mon, 1 Jun 2026 02:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780281544; cv=none; b=sgH9A1F5D+lhCXRBRQ/Lu0gvAWtZIxUmdjc0ILrm/P1sF2Dmp83j+qr2N9nWm4sqx/tp1fFKJTh645mVqS6HDSVLrkDB73NVyXdUDTdaHPS0VzO/3hxbc2Mk335WCxF0/P/qEFkkxpjBo4FWMOir9rNG/j9W9tOEZ+0gKzwfDvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780281544; c=relaxed/simple; bh=E5Sjn2yURtroB92Kl6+8gE5/WtDOFsolZL/dz0K6dT0=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=PHcPfjRx16cyinEP2v7VatEQUyjRviNDInEwmQor1sJP0cke62MyHY5qhUEbS14rV9Q6oRgIjrOY6baLeJfKcI5Wd7fFyOCJr5EZ/s5j2Y9oeWia4hfN+hW0DA0FG3emrMm26oQNyRDE0DrPHskj0tMes9vwTw3yZrvbQKSzW3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TDDX08vn; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TDDX08vn" Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780281540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMfLFxpky3lTG4VESTITwc7VxCTjEnXZROlAXcq5Ry8=; b=TDDX08vnWpAHdaPWUgxv4HK+ImGI1p1k1QKOb38Vudzh3N3QUM5v/eX5xFmmhtIefELXju 4UZ7Wl5j/ebLQd7Gin6uOtLZ4fDy2pa/u+IMWqvr9PRgOHn7YoCZTPC+H+lL2KVr98cOx3 LF3RH+R9aTXdXh5/jHt3YmodWU+F+W4= Date: Mon, 01 Jun 2026 02:38:58 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Kunwu Chan" Message-ID: <3353788b10ec296dcb549abfeaf29fe845574dc8@linux.dev> TLS-Required: No Subject: Re: [PATCH 0/5] selftests/damon: misc fixes for test bugs To: "SeongJae Park" Cc: "SeongJae Park" , shuah@kernel.org, damon@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kunwu Chan" In-Reply-To: <20260531170807.99856-1-sj@kernel.org> References: <20260531170807.99856-1-sj@kernel.org> X-Migadu-Flow: FLOW_OUT June 1, 2026 at 1:08 AM, "SeongJae Park" wrote: >=20 >=20On Sun, 31 May 2026 16:56:28 +0800 Kunwu Chan = wrote: >=20 >=20>=20 >=20> From: Kunwu Chan > >=20=20 >=20> This series fixes several bugs in the DAMON selftests. Most are > > trivial but cause tests to silently pass when they shouldn't, or > > fail prematurely on slow machines. > >=20 >=20Thank you for sharing these great changes, Kunwu and Lian! >=20 >=20>=20 >=20> Patch 1 fixes mutable default arguments in DamonCtx.__init__() > > that cause state to leak between test instances. > >=20=20 >=20> Patch 2 fixes a trailing comma in DamosFilter that turns > > memcg_path from a string into a tuple, silently breaking memcg > > filter setup. > >=20=20 >=20> Patch 3-4 fix bugs in damos_tried_regions.py: wrong operator > > precedence drops the "not met" prefix from failure output, and > > empty early aggregation cycles cause premature test failure. > >=20=20 >=20> Patch 5 fixes several wrong strings that produce dead elif > > branches, skipped file existence checks, and broken dict key > > lookups. > >=20 >=20I left comments to each patch. To summarize, >=20 >=20Patches 1, 3 and 5 look good except signer/author info mismatch. >=20 >=20For patches 2 and 4, I think we need more discussions. >=20 Thanks,=20SJ. Noted. I'll fix the signer/author mismatch in v2. As discussed in the individual replies, I'll drop patches 2 and 4 for now and revisit 4 once the underlying issues are better understood. Thanks, Kunwu > Thanks, > SJ >=20 >=20[...] >