DAMON development mailing list
 help / color / mirror / Atom feed
From: Enze Li <lienze@kylinos.cn>
To: SJ Park <sj@kernel.org>
Cc: damon@lists.linux.dev,  linux-mm@kvack.org,  enze.li@gmx.com
Subject: Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid
Date: Fri, 17 Jul 2026 16:46:26 +0800	[thread overview]
Message-ID: <875x2ej95p.fsf@kylinos.cn> (raw)
In-Reply-To: <20260716135438.101815-1-sj@kernel.org>


Hi SJ,

Thank you for your review.

On Thu, Jul 16 2026 at 06:54:37 AM -0700, SJ Park wrote:
> Hello Enze,
>
>
> Thank you for this patch!
>
> On Thu, 16 Jul 2026 17:14:44 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> Document 'target_pid' via MODULE_PARM_DESC so its meaning is visible
>> through kernel command line usage and sysfs interface.
>
> But...  It is a static module.  Is there a way to read this documentation from
> the user space?  If there is no such a way, I don't really think this change is
> needed.  If we want to document this, we could use comments.

AFAIK, MODULE_PARM_DESC() is for loadable modules.  For builtins, it’s
effectively just a comment.  That said, if DAMON gains loadable module
support later, having these descriptors in place means we won’t need to
touch the code. WDYT？

Thanks,
Enze

<...>

  reply	other threads:[~2026-07-17  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  9:14 [PATCH] samples/damon/prcl: add module parameter description for target_pid Enze Li
2026-07-16 13:54 ` SJ Park
2026-07-17  8:46   ` Enze Li [this message]
2026-07-17 14:23     ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875x2ej95p.fsf@kylinos.cn \
    --to=lienze@kylinos.cn \
    --cc=damon@lists.linux.dev \
    --cc=enze.li@gmx.com \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox