From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A072142CB0E for ; Thu, 9 Jul 2026 15:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612638; cv=none; b=Dvi/cztwXYod/qFxvLdAOOTjoi5LcUjlsmEkJ+8sdH8XSOf6yb1u0f+t+TvtJqR9JeM1lAbRZhFBfkgDmCwUiv32RNo48ql7VJzj28J0ijrOeWbGAx/mD2Fs4ngb87aBvQV7K1QvHnZ9h3PHVL2tVkDcOeMFAHHigyXa0owZ/PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612638; c=relaxed/simple; bh=zOqJj5IGDkUHkuE0A0VjkQNttgCPQIdWlZYAcSbicnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lBtIeJCmfeJ2QoptStLT3oSyYVsnG66pZyBL0zfkCEcK/QlLSbxQu0kpEZI4kgpVHwHEnSU/wnPMRlQAvFLKkcTnp1uyW1SUHnjXhK04MfxEBIeYFFPx7mQspASJ4COkVOVIdWMPHmw1pMKlvO4PXcfzCjBFJr0M6SxTl2KFSJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=Izkg+ycr; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="Izkg+ycr" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8eefd4a8057so1011996d6.0 for ; Thu, 09 Jul 2026 08:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783612635; x=1784217435; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=T5BtG8ZZnILhla7gs7f63UlRSUpFIkMkPS04TXxov0k=; b=Izkg+ycrCyOCViNSSPP/Do+d2sLA2EbH3MqgIZTEDTFkrkUvu/G73aUE9BG838DnCz d8SeMg/+eL9LHO2TTmHHr7EI/RId1lnfvYqGUP4Zn+Lce14iR++fdUk5txF4BaOd2ZNA olB8K/d6X+nxsp50jZE1vvNelvP52BBoQiRp1uLU4BsqCxBOkMjRl/j3iOhiHgzCM1Xo WyWLvXMG+yWXNKbR2BVjz1sb+4B93DutWF9UzcPAgrJGnWS5Ybu9WwAhDcfc151WlE8v kYZ0vZf7SM7aUWX3j1ITaakgXJy4NQYi6RZGSSaPBlU8druHLboOHcLj4cuiWJIuOtZy hESQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612635; x=1784217435; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T5BtG8ZZnILhla7gs7f63UlRSUpFIkMkPS04TXxov0k=; b=JlDjv2W/3wD1uGsXpuynv4F3wt8HiYmqlMviIgswMSOsfxkqoKjADLqEwK31IOfFfn JRjocJF2cP1CgyRjHlSdJ1s34finqyzlcPyaBdHmr0GQd2GTsDib/y1yzPdBKpJxJfYx AqoDcmrs1K9qYVXUy1bYY+IjPdJ8oCLqvZKB9XEx5xEOAWgXQrAHbocLZouGSgWv2scB tOc2VwDNzHv7EM8eoPnh8ZZ2GzQV8tZqdzAaiRvBHdKce/uIPv/2HBq9vphUyMtotnrN txnDs9IaM7iI9+Rjse06eixmpDNFdMknTLf8KDUamcb5uyX7SZZ0W2Mr2WucPof1hyea lMew== X-Forwarded-Encrypted: i=1; AHgh+RpB2ABDKjBN1Qrgghg6zSMow3Wyw/uepMhtRM9U2IW8k0a+9yfQLNMbILGadKS/8m5cA54exg==@lists.linux.dev X-Gm-Message-State: AOJu0YxwxV3VI5GB/2LD3/3ogrqyFyaa1xl/13PoWc2xTTEsSkPAoORk LDo7epjqIVWp3tnVKlxfUrrscn6DgBBLrmbDCskDiE7gc3Y/Q8GKVYPtuRAbPJI9w30= X-Gm-Gg: AfdE7cldyIgVYErbu6uz8u7Z7XFaHMuy+7fhUulCDCTWxV6dyw0kAwsuM5AZi1SOYiL OtMa4I/WZ27UJ6al72GaiWqw/z9mNSQo/nhsHAYU89+9AB/iBx68gwL12mFDz8cIVOlMrQH87+s VTcvY1mkiYd6wlSscf4v6yzU+tDnERtShGHSBREVatOdukuJC1BgPlFQHGRvam6EbpwlLxORhh7 KUV15QEdK7stl/cfkXz14dqlIVF1T50cMmCDgXYx3qQuz2WG3EQR9BTagYH4pqXopQ9nU/U9eS5 +Bjnq5f1xR+nlU+SGSk9Hv4wOef+92arwSoc/q1klmAaDMF5Mzgtevt7imfpOckaRRBiGROfEEi qMQEKObpENV3d6q6UMk57/UZledcAvlTLraYwU2IpdR5hlm03atGoi3Tw1Wyv1+xMFCHpigHi9W d2/cs9zSAo+Gyqt7h+8ltEdSWuSBd+SWuifxxlpAe8xLZutTdWhUcS+imMjVJlNmUcPdvCM/Yt5 xpArXo= X-Received: by 2002:a05:6214:2aa6:b0:8f3:e0ce:6119 with SMTP id 6a1803df08f44-8fec0ead52amr91789316d6.21.1783612635560; Thu, 09 Jul 2026 08:57:15 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd86d43e2sm20317526d6.43.2026.07.09.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:57:15 -0700 (PDT) Date: Thu, 9 Jul 2026 11:57:09 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently Message-ID: References: Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 09, 2026 at 11:55:54AM -0400, Gregory Price wrote: > > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > > { > > struct comedi_buf_map *bm = vma->vm_private_data; > > unsigned long offset = > > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > > > > Obviously correct, but was this intended for a different patch? > > ~Gregory bleh already caught, sorry for the noise :]