From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00A343E1D02 for ; Thu, 9 Jul 2026 15:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612563; cv=none; b=BkiNNEvT4Ju+lmHY40PlcqQFx8WUpuRss1WANeSP9lH6a8Ub40cXccBaIqUBkTXHpvpRcs97wpaViRTQw/+58x7kSoEC8Cish+kUsZHiMiTBW17mEFJz34ZgN3/2rX7BeP4Q7VP11chbRCqhfJchR+kenjDIAqIat0G/XgJ8uyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612563; c=relaxed/simple; bh=GOt99IJ7fgZPI8QmxyNzz1MEgzG9KnOmLnnihrfLrQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PwXvVs2Z1Z5MJMyBggl4DFiKz0TGAfTJTKld3MAK/QSyKuQno24aGyGGah6VjdAxp9X++ikt2InxblIZs6YLmG3hIOv16D/ZFYHw84a7Hxyn8mqcA1lOCv212viY1Rgsaqx8r2xM5X0q10+coukjrVCGbuljlMwriAudaO1PoII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=dLk059lM; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="dLk059lM" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51c0006ea8eso14533531cf.1 for ; Thu, 09 Jul 2026 08:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783612560; x=1784217360; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QupnWz0oLATZw6wM2bylQaqDWCRhZF5lJVU8oFwJF/g=; b=dLk059lMxxwyK4QlxDjO1LvJGsEC935B3ol0R+gg/T5VsrPIzHZl5HpjMQ0C9Df+qI Zpcut/0/9q00VKszq0ofXqXr3ms5s5M4AEFRA8Xn5jXKYIPTZliWbpqu4whV1oAeXuQP KG+aNqwsixfIXj+pEd6n2PTMGNnUPuhTNMNgpXQ6pLzSmDwGxL+oPRKYIJsxpaGsmcpW 5f3ENDfNQ8z7EVGphdJ6VM5SNT7ZwKniR3JoU11U1G4Ow/OFr8QLaLtfS/vJj67kvJhr Ux/Gji8RDXza/qMamJfD5E2bvZzxtkpVlktMgFKighldEV7aMLADvTwJKUwumZ4kFonW DJeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612560; x=1784217360; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QupnWz0oLATZw6wM2bylQaqDWCRhZF5lJVU8oFwJF/g=; b=RXYNrODKZW0kM0Cf/95WgyqVKtrrSGMTHQuIzUPlnnowmo8p+woMop9cC7Lrs3Tv1Z b2ZUUZNQZWNfAVkYlclIlXKbgLOrve2sPS3fYLbxpB+R7HqWFFMdMIgrMrPeM5sDbMHu Cwxl7/zjQos9chXQB57bmr4vfhBVL7U7YC9dTUn+CPscJp14f2hk0e7uUZu3EM3SnvLx YZw39ALw7PuFx3EBtKMzdJpIoJJZcCq0GrmFT4HI+M590kaUVpBvwuRw+6Y59Td/OvWx sI9oqlchQpRwPrfPOFE2TokM+/PZ2SHOHbqi4K3o/4AOYrzE84L8JSlFWaWn5os4Jdy2 2UgQ== X-Forwarded-Encrypted: i=1; AHgh+Ro3AVH/vGm8cc+5T3+1CcA0F6qV+9YNND9cNEBWWNyaEpixguDHsrOgegTVh4Q3QG/IAulvbg==@lists.linux.dev X-Gm-Message-State: AOJu0Yz2tCmAlbtUZz3EoYrACHV6sTNImzo65F5B+xiexL/FuHhzvY0L xdqyohLBJGpcRu3IBep8R7POAYflwPldIc83zBetT+YIDVercczmhzbMMrNftB9+030= X-Gm-Gg: AfdE7cmdqN0/3qdzgxkkeVJYrHcn/mnc2PKwly2hsfwF7ao63XvhxrKC2mAKhQ1g+pj zgXpxrEoN/kYb2M3h9mloCGMBFwoC6pcqjUJo9cSo/PNHsGKr5Bf1///uMD7uGxAa3ZJzRV9e4v nLMPCRb5BsrLINhuAXGEOH3+LvqSP1W1qjPRvgO9/ePJA5qtzTLUs78ZJ2G3AKPAbe3U8/rG7VI uFvPEMeZn6O58GY/YnobXmR6zsjwbxSZMnwPIN3Wx9npheBXQoMw/uqlzXLY+/+RM0La99n3Ihv 14W27/6uCB4u/SZSbb++TT1nUxiM8UgKp8Yl5mTybAcKhreLkCBkcNAV90Orh1Hxpiz+haLmLe7 EKfIKOmBg2cUVKkfULqtbZmKP0V2PlMmvbvcOr6QFDdr3UxBsnKkpK965SEESq0RI4KPdnX8S7W Wfg1FiF6iL3MIbd03/hkNFq4R0MZ13qERbh1Y0IeKMKKIQNqVWSaHG/NC5agJJ+MFaDGOk X-Received: by 2002:a05:622a:311:b0:51c:185b:29e0 with SMTP id d75a77b69052e-51c8b2ae67bmr82998651cf.10.1783612559586; Thu, 09 Jul 2026 08:55:59 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41d2d688sm169684691cf.17.2026.07.09.08.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:55:59 -0700 (PDT) Date: Thu, 9 Jul 2026 11:55:54 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently Message-ID: References: Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 29, 2026 at 01:23:30PM +0100, Lorenzo Stoakes wrote: > There are a number of places where we open code what linear_page_index() > and linear_page_delta() calculate. > > Replace this code with the appropriate functions for consistency. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes one nit Reviewed-by: Gregory Price ... > diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c > index c09bbe04be6c..536c25d8dcee 100644 > --- a/drivers/comedi/comedi_fops.c > +++ b/drivers/comedi/comedi_fops.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > { > struct comedi_buf_map *bm = vma->vm_private_data; > unsigned long offset = > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > Obviously correct, but was this intended for a different patch? ~Gregory