From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2219380FC0 for ; Fri, 10 Jul 2026 18:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783709851; cv=none; b=GgdyV7lsVNJ7U1TDvgIij2qKoLDrmr56yccZ0VUmJzT7FVpmYxJTGR+z6SLq86ticewoRrPkgTgEk/jM+2x3KSVh13TffncT53cTXi12ZvB3cmH0NfRs3M6w0UWiUJehujvwO+Rdhd8Qsu7bHiqn1rjfN+YEzaISDjxCwSSiHAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783709851; c=relaxed/simple; bh=mfAQ6U6Pagde6/OTMZV/3pa3xVR9imBJSf9e6QtJA6o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BYCRSO0E/mfA+w2ag2LSNhMC6gHlS5NjqupkOaT5PeYLX5MHyqNuz05zJjU/hl7dKqPyK4NIC82yI1WwgjouDH1vgnr3e1w6NPZ5dDU3oabmXb/WE8mTWQag1F7gS8rBry1jBhpeCQ129O6q/zOogAeYKIJAPaGDdAMV5emFB48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=f01Mp37R; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="f01Mp37R" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-92e5b048375so61564585a.1 for ; Fri, 10 Jul 2026 11:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783709847; x=1784314647; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kUriDsQ9XZtRyYKZZfoXUueFFJuZPgSg6lCZHNic6sM=; b=f01Mp37Rvqx+Y5DQaHEiRaHGaE3CXSciZUFtTOLy89uy2S9wF3zm/kJ/11ZiwtJ/Qt /V933YFidtQTmYGlyIo0x+hFsGW+uTYvyaIvsY8apT1lv+CIPNi/i65kcqC+PFL11a4R bMJRJIpHsXnPZOQy8OFkDYdHGAzErqakPqsdD8amfm0+a0auRH594/3VMKjoah5JgCfk eX+3njX0/Gt+GuN0+COYdzLkBohoNFResqTw50DPEnVDWrUl7NIgmhm0MRMePO4x4yNY yxbBxjGtDu3CSAvQp/7eqd8QTfleGdV9EQg9by2+lhFCoYCTrVUt69REpm83AL2PP7au HG4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783709847; x=1784314647; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kUriDsQ9XZtRyYKZZfoXUueFFJuZPgSg6lCZHNic6sM=; b=pYrAi+hu7LNNJs3RCOKUq1oeXloHLQj0WXqmICjVnPzX8fFff+rcLA2+4DJTmyDZwa J8tNq3N7nzQQbd49KaeeCD4vE0ZyNNPErPwI8GUS+lXQDftOWPbeidqTj3Z79TKwn2A9 vrebVmoHJaXRKOvoLCQNpE7o6qiJexRqfDljxqRxiqSxLDy6I7ENVeO9gf4kfnroFqvL MhCsSWsjGfyya21vrCj3YOaAVRFHtI7xRLoeoOMQA7/zYXINOuRioJ81gkq4AaLnOt/Q oYpZodSUmForgUbpeM1gg3p7BCb5XU6qJg1DdtsY71RBu2q/qLBUdkVeliCZsXT4fmSv WXXg== X-Forwarded-Encrypted: i=1; AHgh+RonBLXRpH38OWMgBchu205EFDzjyncmB7kg7E1lesKLd45jb7Cl6uiinXet+flDEQy4D22t6g==@lists.linux.dev X-Gm-Message-State: AOJu0YwjjS0sHCWZykexoXso1hsW5kW3ZjAJsjY0GYKsXVMNWQ66UHZt MzOruiWZAThqMIqXIzrw5tSLAwokEfAw8SnOTJRfZfQ8KZ6uuVNAb+sAMbmYexhNIhs= X-Gm-Gg: AfdE7cn+T4bBHuKhA1ST+mmcx39nqhxFZ7FrcfBT7qWToaLEA0YG7BdirNmfkhdxt2R Frtehm6FwjX3Mt37HsEIqCzwbYEKNwCxFVlY38DPz6+UJPyinw+GL1/uz1DW4kyd7+uYV/EgX+x L/vFPyxjHJPBOeoCE8YNZ/XuMKYDIgSfIU+RpdSPo6H/ram/wM/j4kqkDxBiFPy8daCqBC7UDbS /E58V0ukDrpNdaYbMyxMCUX+IP9bN9uBlvL8dCZ8Gu0MsdayxXN3QyD9srmZrEGrocK2ZjrH1kK tK6ize0hvYCrt4laanOGmX4hhN3IIViJwUHzcRC9XTpe5Q6rGTvvOLpvxfKLDC7LAY3YAURvzRM tR98moE86BLfdOT1y+2r5yRSgeAqx5yNA/6yiOZjd6F/DXhd/0iovBIZFEOIX1enfuA11LDZW5S 3T1RpuWE+JBSulJhgf2ieOapQzXgJE/qSWmAuh3GgjPuS/Znp8sKztZgXHp8Gpaf5u6BoM X-Received: by 2002:a05:620a:d8e:b0:92e:9d63:a6f2 with SMTP id af79cd13be357-92ef2c1ab7bmr45629785a.70.1783709846741; Fri, 10 Jul 2026 11:57:26 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5cfdf6fsm275995385a.24.2026.07.10.11.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 11:57:26 -0700 (PDT) Date: Fri, 10 Jul 2026 14:57:21 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 23/30] mm/vma: make vma_set_range() static, drop insert_vm_struct() decl Message-ID: References: <62efd70f9f39570724c9552cc7f2aeb5c322b2ff.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62efd70f9f39570724c9552cc7f2aeb5c322b2ff.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:34PM +0100, Lorenzo Stoakes wrote: > With __install_special_mapping() moved to vma.c, vma_set_range() can be > made into a static function there and is now completely isolated from the > rest of mm. > > While we're here, we can also remove the insert_vm_struct() declaration > from mm.h - the function is implemented in vma.c and already declared in > vma.h, and has no users outside of mm. > > Also update the VMA userland tests to reflect this change. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > --- > 5 files changed, 8 insertions(+), 24 deletions(-) Net negative lines of code, the best kind of commit Reviewed-by: Gregory Price