From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2457380FCA for ; Fri, 10 Jul 2026 20:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783716548; cv=none; b=L/DH4BN9PpPyqtzX62vblOAzYZ/4chyzBnDu3nfxpFiaxM/V0mzW3MH8kEXiBY0nofSWp6yZICgeM2efY/kI0PctOXWPCRg4Ni8J+vBKJoqpzzdBgzLx6MkJEmQMsiMJCg66AFKa7wf+328fYX9jXKhSeh0QD2XVP+Bl5Kqcvio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783716548; c=relaxed/simple; bh=gC5eUqeAebp3PWfUT6EP2kjPnQImFCyW8H71EpslMQY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EC8eCZ2N3cgpG8G5sGXJzdojgfDHDc3UifWTQ/XJfssEIdP8KNP0NswAS+G2070JQ1r9FXJYuZpHCbf9OJnX3Wb/jXhvLNFzgkIJNDpcCg/837aQrmW8CA+Q3EDx3Cee8+apKhS3nJDHbBuMmcsllQehcq1KbepPNUm0z5VpX2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=Y8KNEOjU; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="Y8KNEOjU" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-51a868b6962so12082151cf.2 for ; Fri, 10 Jul 2026 13:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783716545; x=1784321345; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fM3Bw1AZy4lAkPPHaL59OrI7vB0RIP/keCGdI0vS7tk=; b=Y8KNEOjU05iAKU7TSYKEYWUF5soYf9fExvab3Zk6BFaEGfmsrras5zppLfwO2R0xfA Q+9iNXQyhqo/kMLoBRVbZoL82WyNT3c6DJ0SKPPOfkkDCMyH68r0MregpgJy5aQj2wbH K7yygdOcD188bFhupTslho2x/ghdMcG2hzrzFeaV24cmvZSpcQg4eT8FX1F9L5Jllp61 PjCQg+MKf2GkdweQvjxqPEca2AqijT97V2N1a+Ybu0JBSrx4GlVrCIpbNJBBXi11Zlqn S4y/QXUk8VRzpQ0QzjFgFBa7W1rzyvAAPqA2diU5mkOtDFHHWY+leD6GKeL87Z/FVRGc /J2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783716545; x=1784321345; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fM3Bw1AZy4lAkPPHaL59OrI7vB0RIP/keCGdI0vS7tk=; b=oWAwWdMiOdjcKV3+DrsiX5doF9s6nhtUgaEdlg3qRgigiT4N2CZSPcje0ssPUj9tpw HGNWBe6YJWZTA4EcrWMQO9BO57rnPkJUzBTPF//uAjsqeFcQ+KtK6cV45myJ/ezpjlys 8rE3FKKe+XgMoJoYB4PaECqc8ZVCM1VgfLUNj53nal+zS40Kw0M8uacTVJ4djvlhpnE5 yiWulya4VIRBtBIkUJN5cF9d0WmhX0rMIfyb5wYZ1bdbzMD3+3vhXLoM2T+naNRP3tBj gIN1+cv6izVpdNMv6V9ObZF0ldaaXbwTczkmkPXkZwW39YgBZuVIq76cKGDU+1Kx6aH0 PFdQ== X-Forwarded-Encrypted: i=1; AHgh+Ro4faAfrtjWgs9w70Qgl5c/6CXHLOj1a9K53txippoiZI7hNQCjCalW39OftmhLpwR33LbtUw==@lists.linux.dev X-Gm-Message-State: AOJu0Yxd/nPNyPtlUvnFMIdYL2oXVkmwYaQ43n1kXxoEHah0zk3vunth Gdnllqh2kNvXRvKtIeEt3TmnLPUl+iHQ+6UTonvZJ9PyxckOKSJgHOYShG05IJzeLAk= X-Gm-Gg: AfdE7cnXU/dkBUqgO5CjebbsM9jgf3UOAHBVgGiM/BnaQ/T4fK67b7DlpHA5yh+nZ1I UWvFvyQ3vnY/se5ENuXaoek4vDmbUWnGfz5yfEWGPzY9TyZAKyofG/Q7Y7I0cUlivxzrIGFMzfR kHO7FBtuXjWsIsW4Ndp9sDMYq59yLwiWQDNtpST7FkfH9a9m/jkdRe/aNTCPKQGDkP6+eQ2Sulz PLsK46qHFDbKTnUvOk4CITZjZbXsVOufM9S5V5zjMFr5Z/zg786FxqhVqNbbYf4p1FE3nDRFCU9 DXNxjM6S0KD10rTPQvalc9rRo+jVr495i4fwdKqP8NMKtawd3U+4Hxuhyn/VIm5ziZV0Cp+mqzM im+XyhRoqKGj8hbJl8fJu6k9S+5SAcWJsSErPXT4X4bgf4mW3V+LRcAK9mqoA3xFR98rE1S5dU8 xag0HOu94A5ecR5WUVi256sKymgU7xwaSSQwlFbWogo9Rh2Rv3LkJzy1UCMZpCw/DEgibc X-Received: by 2002:a05:622a:15c4:b0:51c:7b11:41a3 with SMTP id d75a77b69052e-51cbf361a3bmr5658901cf.80.1783716544856; Fri, 10 Jul 2026 13:49:04 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51caaf5f61csm24147321cf.22.2026.07.10.13.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 13:49:04 -0700 (PDT) Date: Fri, 10 Jul 2026 16:48:58 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 30/30] tools/testing/vma: output compared expression on ASSERT_[EQ, NE]() Message-ID: References: <432444fa4c12ae1c4047550e2b205d3e9bab458f.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <432444fa4c12ae1c4047550e2b205d3e9bab458f.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:41PM +0100, Lorenzo Stoakes wrote: > -#define ASSERT_TRUE(_expr) \ > - do { \ > - if (!(_expr)) { \ > - fprintf(stderr, \ > - "Assert FAILED at %s:%d:%s(): %s is FALSE.\n", \ > - __FILE__, __LINE__, __FUNCTION__, #_expr); \ > - return false; \ > - } \ > +#define __ASSERT_TRUE(_expr, _fmt, ...) \ > + do { \ > + if (!(_expr)) { \ > + fprintf(stderr, \ > + "Assert FAILED at %s:%d:%s(): %s is FALSE" \ > + _fmt ".\n", \ > + __FILE__, __LINE__, __FUNCTION__, #_expr \ > + __VA_OPT__(,) __VA_ARGS__); \ > + return false; \ > + } \ > } while (0) > > +#define __TO_SCALAR(x) ((unsigned long long)(uintptr_t)(x)) > + > +#define ASSERT_TRUE(_expr) __ASSERT_TRUE(_expr, "") Mmmmm... macro madness.... I don't think this is what you want. I think you end up double-running the expression in the failure branch. ASSERT_EQ(cleanup_mm(&mm, &vmi), 2) run through the preprocessor expands to: do { if (!( (cleanup_mm(&mm, &vmi)) == (2) )) { **** first run **** fprintf(stderr, "Assert FAILED at %s:%d:%s(): %s is FALSE" " (0x%llx != 0x%llx)" ".\n", "merge.c", 645, __FUNCTION__, "(cleanup_mm(&mm, &vmi)) == (2)", ((unsigned long long)(uintptr_t)(cleanup_mm(&mm, &vmi))), **** second run **** ((unsigned long long)(uintptr_t)(2))); return false; } } while (0); A bunch of existing ASSERT callers mutate state, so there's no guarantee the printed value matches teh actual test value. I think you want something like: #define ASSERT_EQ(_val1, _val2) do { \ __auto_type _v1 = (_val1); \ __auto_type _v2 = (_val2); \ __ASSERT_TRUE(_v1 == _v2, " (0x%llx != 0x%llx)", \ __TO_SCALAR(_v1), __TO_SCALAR(_v2)); \ } while (0) which expands to: do { __auto_type _v1 = (cleanup_mm(&mm, &vmi)); __auto_type _v2 = (2); do { if (!(_v1 == _v2)) { fprintf(stderr, "...FALSE (0x%llx != 0x%llx).\n", "merge.c", 645, __FUNCTION__, "_v1 == _v2", ((unsigned long long)(uintptr_t)(_v1)), ((unsigned long long)(uintptr_t)(_v2))); return false; } } while (0); } while (0); ~Gregory