From: sashiko-bot@kernel.org
To: "Daemyung Kang" <charsyam@gmail.com>, damon@lists.linux.dev
Subject: Re: [PATCH] mm/damon/vaddr: preserve migration weights above UINT_MAX
Date: Tue, 27 Oct 2026 03:57:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-186062@kernel.org> (raw)
In-Reply-To: <20261027035431.1007584-1-charsyam@gmail.com>
> DAMOS migration accepts an unsigned int weight for each destination,
> but sums the weights into an unsigned int. If the total wraps to zero,
> no folio is migrated. Other wrapped totals select the wrong node.
>
> Sum weights into a u64 once per migration walk. Keep the existing
> 32-bit divisor path for totals up to UINT_MAX and use a 64-bit remainder
> for larger totals. Add KUnit coverage for the actual summing path and
> for destination selection at the overflow boundary.
>
> Fixes: 19c1dc15c859 ("mm/damon/vaddr: use damos->migrate_dests in migrate_{hot,cold}")
> Signed-off-by: Daemyung Kang <charsyam@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261027035431.1007584-1-charsyam@gmail.com?part=1
next prev parent reply other threads:[~2026-10-27 3:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 3:54 [PATCH] mm/damon/vaddr: preserve migration weights above UINT_MAX Daemyung Kang
2026-10-27 3:57 ` sashiko-bot [this message]
2026-10-27 6:45 ` Aveline Noir
2026-10-27 13:53 ` SJ Park
2026-10-27 23:57 ` CharSyam
2026-10-28 0:54 ` SJ Park
2026-10-28 14:44 ` CharSyam
2026-10-28 15:00 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-186062@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=charsyam@gmail.com \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox