Re: [RFC PATCH 6.12.y 2/2] mm/damon/sysfs: put target pids for apply_inputs() failure

[sashiko-bot@kernel.org]

> damon_sysfs_build_ctx() invokes damon_sysfs_apply_inputs() for setting
> damon_ctx object with user inputs.  If it is configured for virtual
> address spaces monitoring, the setup also increases reference counts of
> monitoring target pids.  If the setup is failed, damon_sysfs_build_ctx()
> deallocates the damon_ctx object without decreasing the reference counts
> of the pids.  If the failure happened after increasing reference counts
> of pids, the pids can be leaked.
> 
> Fix the leaks by decreasing the pid reference counts before deallocating
> the damon_ctx object.
> 
> The issue was discovered [1] by Sashiko.
> 
> [1] https://lore.kernel.org/20260730040740.140836-1-sj@kernel.org
> 
> Fixes: 74bd8b7d2f8e ("mm/damon/sysfs: move targets setup code to a separated function")
> Cc: <stable@vger.kernel.org> # 5.19.x
> Signed-off-by: SJ Park <sj@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028042617.165657-1-sj@kernel.org?part=2