From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH] selftests/damon/sysfs_memcg_path_leak: define ksft_skip
Date: Fri, 30 Oct 2026 04:48:45 +0000 [thread overview]
Message-ID: <sashiko-outbox-190316@kernel.org> (raw)
In-Reply-To: <20261030044643.157105-1-sj@kernel.org>
> sysfs_memcg_path_leak test uses $ksft_skip without defining it. As a
> result, the test is marked as passed while it was skipped, like below.
>
> $ ./sysfs_memcg_path_leak.sh
> Run as root
> $ echo $?
> 0
>
> Users who run the test could therefore wrongly believe the test was run
> and passed while it was skipped.
>
> Define the value at the beginning of the test. After this patch, the
> exit code reflects the skip.
>
> $ ./sysfs_memcg_path_leak.sh
> Run as root
> $ echo $?
> 4
>
> Fixes: dfa3cf0bc018 ("selftets/damon: add a test for memcg_path leak")
> Cc: <stable@vger.kernel.org> # 6.17.x
> Closes: https://sashiko.dev/#/bug/linux-a0456336-0608-4fec-ac22-0ee61d1d6a91
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030044643.157105-1-sj@kernel.org?part=1
prev parent reply other threads:[~2026-10-30 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 4:46 [RFC PATCH] selftests/damon/sysfs_memcg_path_leak: define ksft_skip SJ Park
2026-10-30 4:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-190316@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox