Re: [PATCH mm-hotfixes-unstable 3/3] selftests/damon/sysfs_memcg_path_leak: define ksft_skip

[sashiko-bot@kernel.org]

> sysfs_memcg_path_leak test uses $ksft_skip without defining it.  As a
> result, the test is marked as passed while it was skipped, like below.
> 
>     $ ./sysfs_memcg_path_leak.sh
>     Run as root
>     $ echo $?
>     0
> 
> Users who run the test could therefore wrongly believe the test was run
> and passed while it was skipped.
> 
> Define the value at the beginning of the test.  After this patch, the
> exit code reflects the skip.
> 
>     $ ./sysfs_memcg_path_leak.sh
>     Run as root
>     $ echo $?
>     4
> 
> Fixes: dfa3cf0bc018 ("selftets/damon: add a test for memcg_path leak")
> Cc: <stable@vger.kernel.org> # 6.17.x
> Closes: https://sashiko.dev/#/bug/linux-a0456336-0608-4fec-ac22-0ee61d1d6a91
> Reviewed-by: Aveline Noir <jm5905938@gmail.com>
> Tested-by: Aveline Noir <jm5905938@gmail.com>
> Signed-off-by: SJ Park <sj@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102144627.88843-1-sj@kernel.org?part=3