From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 6.12.y 2/5] mm/damon/paddr: respect folio end for DAMOS actions except STAT
Date: Sun, 08 Nov 2026 19:58:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-203998@kernel.org> (raw)
In-Reply-To: <20261108195145.115792-3-sj@kernel.org>
> A few functions for applying DAMOS actions including pageout, lru_[de]prio
> and migrate_{hot,cold} in DAMON physical address space operation set
> (paddr) collect folios of the given region by getting the folios of
> region-internal addresses. Then, those functions apply the action to the
> collected folios at once. The collection starts from the region start
> address and advances the address by the size of the folio of the address
> until it goes out of the region. If the start address is in the middle of
> a large folio, and if the next folios are small, some of the next folios
> could be skipped. Fix the issue by advancing the address to exactly the
> start address of the next folio.
>
> The user impact is that DAMOS action is applied to less than expected
> amount of memory. Given the best effort nature of DAMON, it is no big
> problem, but it is clearly a bug that is better to be fixed.
>
> The issue was discovered [1] by Sashiko.
>
> Link: https://lore.kernel.org/20260901131850.98037-4-sj@kernel.org
> Link: https://lore.kernel.org/20260517234112.89245-1-sj@kernel.org [1]
> Fixes: 3a06696305e7 ("mm/damon/ops: have damon_get_folio return folio even for tail pages")
> Signed-off-by: SJ Park <sj@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108195145.115792-1-sj@kernel.org?part=2
next prev parent reply other threads:[~2026-11-08 19:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 19:51 [PATCH 6.12.y 0/5] mm/damon: porting fixes that cherry-pick failed on 2026-11-07 SJ Park
2026-11-08 19:51 ` [PATCH 6.12.y 1/5] mm/damon/core: skip applying scheme if region split for quota fails SJ Park
2026-11-08 20:00 ` sashiko-bot
2026-11-08 20:07 ` SJ Park
2026-11-08 19:51 ` [PATCH 6.12.y 2/5] mm/damon/paddr: respect folio end for DAMOS actions except STAT SJ Park
2026-11-08 19:58 ` sashiko-bot [this message]
2026-11-08 19:51 ` [PATCH 6.12.y 3/5] mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total SJ Park
2026-11-08 20:03 ` sashiko-bot
2026-11-08 20:13 ` SJ Park
2026-11-08 19:51 ` [PATCH 6.12.y 4/5] mm/damon/core: filter out damos address filter-split failed region SJ Park
2026-11-08 19:58 ` sashiko-bot
2026-11-08 19:51 ` [PATCH 6.12.y 5/5] mm/damon/core: remove unreachable damos charge_{target,addr}_from SJ Park
2026-11-08 20:07 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203998@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox