From: sashiko-bot@kernel.org
To: "Yifan Feng" <evanfengff@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH] mm/damon/core: fix damos_walk() hang with zero watermarks interval
Date: Wed, 18 Nov 2026 23:57:23 +0000 [thread overview]
Message-ID: <sashiko-outbox-222220@kernel.org> (raw)
In-Reply-To: <20261118235012.14859-1-evanfengff@gmail.com>
> kdamond_wait_activation() cancels damos_walk() requests while all
> schemes are deactivated by their watermarks. But it returns without
> waiting when the watermarks check interval of a deactivated scheme is
> zero, which is the default of the DAMON sysfs interface. The kdamond
> main loop then runs with all schemes deactivated.
>
> In that state, kdamond_apply_schemes() finds no scheme to apply and
> returns before it calls damos_walk_complete(). The walk request is
> neither completed nor cancelled, so damos_walk() waits until the
> watermarks activate a scheme again, possibly forever.
>
> For example, with a scheme that has the free_mem_rate metric, zero
> interval_us and a high watermark below the current free memory rate,
> writing update_schemes_tried_regions to the kdamond state file never
> returns and cannot be killed. The writer holds damon_sysfs_lock, so all
> other DAMON sysfs writes including "off" fail with -EBUSY meanwhile.
>
> Do not skip the deactivated schemes when deciding whether
> kdamond_apply_schemes() has something to do. damon_do_apply_schemes()
> still skips them, so no action is applied, and the walk is completed
> with no region for them, as it already is when another scheme is
> activated.
>
> Fixes: bf0eaba0ff9c ("mm/damon/core: implement damos_walk()")
> Cc: <stable@vger.kernel.org> # 6.14.x
> Signed-off-by: Yifan Feng <evanfengff@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118235012.14859-1-evanfengff@gmail.com?part=1
next prev parent reply other threads:[~2026-11-18 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 23:50 [PATCH] mm/damon/core: fix damos_walk() hang with zero watermarks interval Yifan Feng
2026-11-18 23:57 ` sashiko-bot [this message]
2026-11-19 1:42 ` SJ Park
2026-11-20 0:13 ` Yifan Feng
2026-11-20 0:31 ` sashiko-bot
2026-11-20 0:49 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222220@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=evanfengff@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox