From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>, "Andrew Morton" <akpm@linux-foundation.org>
Cc: damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH 14/27] mm/damon/paddr: support REPORT_MADE type probe filter
Date: Sat, 21 Nov 2026 21:11:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-227387@kernel.org> (raw)
In-Reply-To: <20261121210013.130397-15-sj@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mm/damon/paddr: 64-bit phys_addr_t truncation in
damon_pa_filter_match()
--
commit 28e4b56e5a2332a155374f4f6e67e8b3da9ffb34
Author: SJ Park <sj@kernel.org>
mm/damon/paddr: support REPORT_MADE type probe filter
This commit adds DAMON_FILTER_TYPE_REPORT_MADE probe filter support to the
physical address space operation set by querying damon_report_exist() over
the last sampling interval.
> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
> index e89cb14ee17be..4003ae914f1a2 100644
> --- a/mm/damon/paddr.c
> +++ b/mm/damon/paddr.c
> @@ -140,9 +140,10 @@ static void damon_pa_prep_probes(struct damon_ctx *ctx, bool set_samples)
> }
>
> static bool damon_pa_filter_match(struct damon_filter *filter,
> - struct folio *folio)
> + struct folio *folio, phys_addr_t pa, struct damon_ctx *ctx)
> {
> bool matched = false;
> + struct damon_addr_range addr_range;
>
> switch (filter->type) {
> case DAMON_FILTER_TYPE_PGIDLE_UNSET:
> @@ -157,19 +158,27 @@ static bool damon_pa_filter_match(struct damon_filter *filter,
> else
> matched = damon_folio_young(folio) == false;
> break;
> + case DAMON_FILTER_TYPE_REPORT_MADE:
> + addr_range.start = pa;
> + addr_range.end = pa + 1;
> + matched = damon_report_exist(filter->report_type, &addr_range,
> + jiffies -
> + usecs_to_jiffies(ctx->attrs.sample_interval));
> + break;
[Severity: Medium]
Can assigning pa into addr_range.start and addr_range.end truncate 64-bit
physical addresses on 32-bit CONFIG_PHYS_ADDR_T_64BIT kernels?
struct damon_addr_range uses unsigned long for start and end. When
monitoring physical addresses at or above 4 GiB with ctx->addr_unit scaling
on a 32-bit PAE/LPAE system, the upper 32 bits of pa are dropped (and
addr_range.end wraps to 0 when the lower 32 bits of pa are 0xffffffff), so
damon_report_exist() matches against the wrong address range.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121210013.130397-1-sj@kernel.org?part=14
next prev parent reply other threads:[~2026-11-21 21:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 20:59 [PATCH 00/27] mm/damon: let users report their data attribute findings SJ Park
2026-11-21 20:59 ` [PATCH 01/27] mm/damon/api: introduce struct damon_report SJ Park
2026-11-21 20:59 ` [PATCH 02/27] mm/damon/core: implement data attribute report queue SJ Park
2026-11-21 20:59 ` [PATCH 03/27] mm/damon/core: introduce damon_submit_report() SJ Park
2026-11-21 20:59 ` [PATCH 04/27] mm/damon/sysfs: add admin/reports/ directory SJ Park
2026-11-21 20:59 ` [PATCH 05/27] mm/damon/sysfs: add reports/producers/ directory SJ Park
2026-11-21 20:59 ` [PATCH 06/27] mm/damon/sysfs: add producers/nr_producers file SJ Park
2026-11-21 20:59 ` [PATCH 07/27] mm/damon/sysfs: implement report producer directory SJ Park
2026-11-21 20:59 ` [PATCH 08/27] mm/damon/sysfs: implement report producer type and state files SJ Park
2026-11-21 20:59 ` [PATCH 09/27] Docs/mm/damon/design: update for report system SJ Park
2026-11-21 20:59 ` [PATCH 10/27] Docs/admin-guide/mm/damon/usage: update for report producer sysfs SJ Park
2026-11-21 20:59 ` [PATCH 11/27] Docs/ABI/damon: update for report producer sysfs files SJ Park
2026-11-21 20:59 ` [PATCH 12/27] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE SJ Park
2026-11-21 20:59 ` [PATCH 13/27] mm/damon/core: introduce damon_report_exist() SJ Park
2026-11-21 20:59 ` [PATCH 14/27] mm/damon/paddr: support REPORT_MADE type probe filter SJ Park
2026-11-21 21:11 ` sashiko-bot [this message]
2026-11-21 21:19 ` SJ Park
2026-11-21 20:59 ` [PATCH 15/27] mm/damon/sysfs: add filter_report_type file under probe filter directory SJ Park
2026-11-21 21:00 ` [PATCH 16/27] mm/damon/sysfs: support REPORT_MADE type probe filter setup SJ Park
2026-11-21 21:00 ` [PATCH 17/27] Docs/mm/damon/design: update for report_made probe filter type SJ Park
2026-11-21 21:00 ` [PATCH 18/27] Docs/admin-guide/mm/damon/usage: update for REPORT_MADE probe filter SJ Park
2026-11-21 21:00 ` [PATCH 19/27] Docs/ABI/damon: " SJ Park
2026-11-21 21:00 ` [PATCH 20/27] mm/damon/api: introduce user_report report type SJ Park
2026-11-21 21:00 ` [PATCH 21/27] mm/damon/sysfs: add user_report support for report type input SJ Park
2026-11-21 21:00 ` [PATCH 22/27] mm/damon/sysfs: implement report producer addr_{start,end} files SJ Park
2026-11-21 21:00 ` [PATCH 23/27] mm/damon/sysfs: implement submit command for report producer SJ Park
2026-11-21 21:00 ` [PATCH 24/27] selftests/damon/sysfs.sh: add basic tests for admin/reports/ SJ Park
2026-11-21 21:00 ` [PATCH 25/27] Docs/mm/damon/design: update for user report support SJ Park
2026-11-21 21:00 ` [PATCH 26/27] Docs/admin-guide/mm/damon/usage: update for user_report " SJ Park
2026-11-21 21:00 ` [PATCH 27/27] Docs/ABI/damon: " SJ Park
2026-11-21 21:12 ` [PATCH 00/27] mm/damon: let users report their data attribute findings sashiko-bot
2026-11-21 21:22 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227387@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox