From: Harald van Dijk <harald@gigawatt.nl>
To: Denys Vlasenko <dvlasenk@redhat.com>,
dash@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: Looking at "int vforked" in signal handler is racy
Date: Sat, 9 Aug 2025 14:52:17 +0100 [thread overview]
Message-ID: <031e429e-e20c-4856-91dd-aedef155aae5@gigawatt.nl> (raw)
In-Reply-To: <dadfa485-b5ee-30d7-7154-362cf2eb04cd@redhat.com>
Hi,
On 09/08/2025 14:29, Denys Vlasenko wrote:
> struct job *vforkexec(union node *n, char **argv, const char *path, int
> idx)
> {
> struct job *jp;
> int pid;
>
> jp = makejob(1);
>
> sigblockall(NULL);
> vforked++;
>
> <<<< Parent can get a signal here.
The sigblockall(NULL) is meant to prevent that from happening. Likewise
for the next one you point out. Is sigblockall(NULL) insufficient for
some reason?
Cheers,
Harald van Dijk
next prev parent reply other threads:[~2025-08-09 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 13:29 Looking at "int vforked" in signal handler is racy Denys Vlasenko
2025-08-09 13:42 ` Denys Vlasenko
2025-08-09 13:52 ` Harald van Dijk [this message]
2025-08-10 19:33 ` Denys Vlasenko
2025-08-10 22:20 ` Harald van Dijk
2025-08-11 5:00 ` Herbert Xu
2025-08-11 12:58 ` Harald van Dijk
2025-08-22 1:32 ` Harald van Dijk
2025-08-24 2:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031e429e-e20c-4856-91dd-aedef155aae5@gigawatt.nl \
--to=harald@gigawatt.nl \
--cc=dash@vger.kernel.org \
--cc=dvlasenk@redhat.com \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox