Re: [PATCH 1/3] Port to Solaris

[Brian Koropoff <bkoropoff@gmail.com>]

I'll send an updated and rebased patch shortly.  Once we've agreed about
what to do with _LARGEFILE64_SOURCE in the HP-UX patch, I'll send a new
version of that as well.

-- Brian

On Thu, 2011-03-10 at 20:16 +0800, Herbert Xu wrote:
> On Fri, Jan 21, 2011 at 01:06:02PM +0000, Jilles Tjoelker wrote:
> >
> > What you can do is use PRIdMAX from <inttypes.h>, normally defined as
> > "jd". You can then define this to "lld" or "jd" if it is not defined.
> > I think this makes the code uglier (just like your change), but oh well.
> 
> I agree.  Brian, please update your patch accordingly.
> 
> Thanks!
> 
> > By the way, I wonder what the advantage of imaxdiv() above separate %
> > and / is. Compilers can detect the matching between a % b and a / b and
> > do it in one operation, and any use of imaxdiv() trips gcc's
> > -Waggregate-return.
> 
> It used to generate smaller code with gcc.  If gcc now knows how
> to optimise it properly then I guess we can remove imaxdiv.
> 
> I just checked and gcc 4.4.5 still generates two divisions without
> imaxdiv.  On the other hand gcc doesn't even inline imaxdiv.
> 
> Cheers,