From: maximilian attems <max@stro.at>
To: dash@vger.kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
klibc@zytor.com
Subject: (fwd) dash fix for job control off warning
Date: Fri, 2 Apr 2010 16:32:20 +0200 [thread overview]
Message-ID: <20100402143220.GC6199@stro.at> (raw)
----- Forwarded message from "H. Peter Anvin" <hpa@zytor.com> -----
Date: Mon, 29 Mar 2010 15:07:01 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: maximilian attems <max@stro.at>
Cc: Colin Watson <cjwatson@ubuntu.com>, klibc@zytor.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Subject: Re: [klibc] [git pull v3] dash, sh4, ipconfig, dprintf, fstype,
README's
On 03/27/2010 05:58 PM, maximilian attems wrote:
> hello hpa!
>
> added on top of queue ext4 fix, that Ubuntu is carrying from cjwatson.
> Got missed out in previous pull requests. Btrfs recognition in fstype.
>
> the patch queue contains sync with latest dash, sh4 fix by Debian porters,
> dprintf usage in ipconfig, kinit and nfsmount instead of buggy DEBUG
> macro. ipconfig memcpy usage to avoid strict aliasing warnings.
> Some interesting README's got renamed for easier packaging.
> Bonus is sparc32 socket test.
>
Pulled this; there seems to be a problem with the new version of dash
with job control off. I can't tell if it is just a warning or is a
manifest bug.
The solution is simple:
--- a/usr/dash/jobs.h
+++ b/usr/dash/jobs.h
@@ -105,5 +105,5 @@ int waitforjob(struct job *);
int stoppedjobs(void);
#if ! JOBS
-#define setjobctl(on) /* do nothing */
+#define setjobctl(on) ((void)(on)) /* do nothing */
#endif
... to keep the code syntactically valid even when setjobctl() is used
as the body of an if statement.
-hpa
----- End forwarded message -----
--
maks
next reply other threads:[~2010-04-02 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 14:32 maximilian attems [this message]
2010-04-02 14:42 ` (fwd) dash fix for job control off warning Herbert Xu
2010-04-02 14:47 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402143220.GC6199@stro.at \
--to=max@stro.at \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=klibc@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox