From: maximilian attems <max@stro.at>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: klibc@zytor.com, dash@vger.kernel.org
Subject: Re: [PATCH] [SHELL] Fix klibc DEBUG compilation v2
Date: Sun, 10 Jul 2011 18:35:18 +0200 [thread overview]
Message-ID: <20110710163518.GA31095@stro.at> (raw)
In-Reply-To: <20110708085501.GD28449@gondor.apana.org.au>
On Fri, 08 Jul 2011, Herbert Xu wrote:
> On Sat, Jun 04, 2011 at 09:15:49AM +0200, maximilian attems wrote:
> > dash didn't compile in DEBUG mode against klibc for all long time.
> > Now it only fails at link stage for not having setlinebuf(3) and
> > freopen(3).
> >
> > Fixes:
> >
> > usr/dash/show.o: In function `opentrace':
> > show.c:(.text+0x36): undefined reference to `freopen'
> > show.c:(.text+0x86): undefined reference to `setlinebuf'
> >
> > Skip setlinebuf and use fclose/fopen inside SMALL.
> >
> > Signed-off-by: maximilian attems <max@stro.at>
>
> Please change this to use a klibc-specific ifdef instead of everyone
> that uses SMALL.
>
ok, sent patch with klibc specific '__KLIBC__`.
noticed latest dash release, will sync soon.
unfortunately ee5cbe9fd6bc02f31b4d955606288de36c3d4eab complicates
a bit klibc sync, because mktokens now generates a third file
(we already have Kbuild hacks for the 2 generated files).
thank you.
--
maks
prev parent reply other threads:[~2011-07-10 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 7:15 [PATCH] [SHELL] Fix klibc DEBUG compilation v2 maximilian attems
2011-07-08 8:55 ` Herbert Xu
2011-07-10 16:35 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110710163518.GA31095@stro.at \
--to=max@stro.at \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=klibc@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox