From: Herbert Xu <herbert@gondor.apana.org.au>
To: Harald van Dijk <harald@gigawatt.nl>
Cc: Andrej Shadura <andrew.shadura@collabora.co.uk>,
dash@vger.kernel.org, Michael Biebl <biebl@debian.org>,
974705@bugs.debian.org
Subject: Re: Changes to job handling cause hangs in wait
Date: Tue, 1 Dec 2020 21:53:28 +1100 [thread overview]
Message-ID: <20201201105328.GA28341@gondor.apana.org.au> (raw)
In-Reply-To: <861e7a14-3dfc-83f7-8872-714b333d4246@gigawatt.nl>
On Tue, Dec 01, 2020 at 10:50:19AM +0000, Harald van Dijk wrote:
>
> This used to exit immediately, leaving the sleep process running in the
> background without waiting for it. On the dash that's currently provided by
> Ubuntu, based on 0.5.10.2, it still behaves that way. With current dash from
> Git, it does not. This is clearly a change in behaviour in dash not in
> response to any bug (real or not) in bash.
I'm not suggesting it's a bug in bash. If anything it's a bug
in the script. You should never do a naked wait unless you are
sure that there are no other children around that you don't know of.
In the original bug, the proper solution is to wait on the PID
that the script just sent a kill signal to.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-12-01 10:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 10:29 Changes to job handling cause hangs in wait Andrej Shadura
2020-11-17 3:33 ` Herbert Xu
2020-12-01 5:38 ` Herbert Xu
2020-12-01 5:42 ` Herbert Xu
2020-12-01 6:06 ` Herbert Xu
2020-12-01 6:56 ` Herbert Xu
2020-12-01 23:21 ` Michael Biebl
2020-12-01 23:26 ` Herbert Xu
2020-12-02 5:31 ` [PATCH] jobs: Only block in waitcmd on first run Herbert Xu
2020-12-03 12:27 ` Changes to job handling cause hangs in wait Michael Biebl
2020-12-07 3:55 ` Herbert Xu
2020-12-03 12:49 ` Michael Biebl
2020-12-01 10:14 ` Harald van Dijk
2020-12-01 10:34 ` Herbert Xu
2020-12-01 10:50 ` Harald van Dijk
2020-12-01 10:53 ` Herbert Xu [this message]
2020-12-01 10:55 ` Harald van Dijk
2020-12-01 10:56 ` Herbert Xu
2020-12-01 10:59 ` Harald van Dijk
2020-12-01 11:01 ` Herbert Xu
2020-12-01 13:04 ` Michael Biebl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201105328.GA28341@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=974705@bugs.debian.org \
--cc=andrew.shadura@collabora.co.uk \
--cc=biebl@debian.org \
--cc=dash@vger.kernel.org \
--cc=harald@gigawatt.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox