From: Jilles Tjoelker <jilles@stack.nl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: DASH Mailing List <dash@vger.kernel.org>
Subject: Re: [PATCH] expand: Check d_type in expmeta before recursing
Date: Tue, 4 Jun 2024 23:28:35 +0200 [thread overview]
Message-ID: <20240604212835.GA6709@stack.nl> (raw)
In-Reply-To: <ZlvMLrrmMR92Bbvq@gondor.apana.org.au>
On Sun, Jun 02, 2024 at 09:34:38AM +0800, Herbert Xu wrote:
> If the directory pointer is not a directory or symlink, do not
> recurse into expmeta.
> + if (c && dp->d_type != DT_DIR && dp->d_type != DT_LNK)
> + goto check_int;
Good idea, but DT_UNKNOWN might also be a directory or a symlink to one.
--
Jilles Tjoelker
next prev parent reply other threads:[~2024-06-04 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 1:34 [PATCH] expand: Check d_type in expmeta before recursing Herbert Xu
2024-06-04 21:28 ` Jilles Tjoelker [this message]
2024-06-08 3:42 ` [v2 PATCH] " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604212835.GA6709@stack.nl \
--to=jilles@stack.nl \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox