From: Eric Blake <eblake@redhat.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Jilles Tjoelker <jilles@stack.nl>,
harald@redhat.com, dash@vger.kernel.org
Subject: Re: [PATCH] var.c: check for valid variable name before printing in "export -p"
Date: Sat, 25 Feb 2012 07:53:24 -0700 [thread overview]
Message-ID: <4F48F5E4.2010109@redhat.com> (raw)
In-Reply-To: <20120225143155.GA31891@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On 02/25/2012 07:31 AM, Herbert Xu wrote:
> On Sat, Feb 25, 2012 at 03:30:04PM +0100, Jilles Tjoelker wrote:
>>
>> Most shells pass the environment variable through, such as bash, zsh,
>> ksh93 and most ash derivatives. However, the original Bourne shell and
>> pdksh/mksh do not.
>
> Do you know of any genuine uses of such environment variables?
POSIX states that applications must not rely on such pass-through:
http://austingroupbugs.net/view.php?id=168
So while it might indeed be useful to pass through invalid names, such
an application is broken for expecting it to work, and I'm okay with
this patch as-is.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-02-25 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 10:48 [PATCH] var.c: check for valid variable name before printing in "export -p" harald
2012-02-25 7:36 ` Herbert Xu
2012-02-25 14:30 ` Jilles Tjoelker
2012-02-25 14:31 ` Herbert Xu
2012-02-25 14:53 ` Eric Blake [this message]
2012-02-25 14:54 ` Herbert Xu
2012-02-25 15:09 ` Jilles Tjoelker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F48F5E4.2010109@redhat.com \
--to=eblake@redhat.com \
--cc=dash@vger.kernel.org \
--cc=harald@redhat.com \
--cc=herbert@gondor.hengli.com.au \
--cc=jilles@stack.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox