From: Eric Blake <eblake@redhat.com>
To: Chema Gonzalez <chema@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: dash@vger.kernel.org
Subject: Re: [PATCH dash] [BUILTIN] ensure LC_COLLATE is not overriden
Date: Tue, 05 Aug 2014 11:09:14 -0600 [thread overview]
Message-ID: <53E10FBA.5070905@redhat.com> (raw)
In-Reply-To: <1407256813-30944-1-git-send-email-chema@google.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On 08/05/2014 10:40 AM, Chema Gonzalez wrote:
> If the user environment has either LC_ALL or LANG defined, the setting
> of LC_COLLATE in src/mkbuiltins is overriden. With a non-POSIX locale,
> the orders of dotcmd (remember that '.' is 0x2e in ascii) and truecmd
> (':' is 0x3a in ascii) are reversed, which makes the ":" command fail
> in the bsearch.
>
> - }}' $temp | LC_COLLATE=C sort -k 1,1 | tee $temp2 | awk '{
> + }}' $temp | LC_ALL= LANG= LC_COLLATE=C sort -k 1,1 | tee $temp2 | awk '{
Setting LC_ALL= to the empty string risks implementation-defined
behavior. Also, LC_ALL overrides LANG and LC_COLLATE. It should be
sufficient to merely do:
}}' $temp | LC_ALL=C sort -k 1,1 | tee $temp2 | awk '{
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-05 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 16:40 [PATCH dash] [BUILTIN] ensure LC_COLLATE is not overriden Chema Gonzalez
2014-08-05 17:00 ` Jérémie Courrèges-Anglas
2014-08-05 17:11 ` Chema Gonzalez
2014-08-05 17:09 ` Eric Blake [this message]
2014-08-05 17:12 ` Chema Gonzalez
2014-08-05 17:14 ` Eric Blake
2014-08-05 17:19 ` Chema Gonzalez
2014-08-05 17:30 ` Eric Blake
2014-08-22 23:08 ` Chema Gonzalez
2014-08-22 23:08 ` [PATCH dash v2] " Chema Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E10FBA.5070905@redhat.com \
--to=eblake@redhat.com \
--cc=chema@google.com \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox