From: Eric Blake <eblake@redhat.com>
To: Olof Johansson <olof@ethup.se>
Cc: dash@vger.kernel.org
Subject: Re: 'set' leaks garbage from environment
Date: Tue, 30 Sep 2014 09:20:52 -0600 [thread overview]
Message-ID: <542ACA54.50201@redhat.com> (raw)
In-Reply-To: <20140930151449.GB22440@brutus.ethup.se>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On 09/30/2014 09:14 AM, Olof Johansson wrote:
> On 2014-09-30 09:01 -0600, Eric Blake wrote:
>> $ dash -c 'unset "a|b"
>> $ echo $?
>> 0
>
> Works for me (tested on both Debian package versions 0.5.7-3 (wheezy)
> and 0.5.7-4 (unstable)):
Serves me right from testing on multiple machines :(
I mixed up my test results.
Fedora 20 using dash 0.5.7 works:
$ dash -c 'unset "a|b"'
dash: 1: unset: a|b: bad variable name
$ rpm -q dash
dash-0.5.7-8.fc20.x86_64
But RHEL 6 fails:
$ dash -c 'unset "a|b"'
$ rpm -q dash
dash-0.5.5.1-4.el6.x86_64
so this is at least one bug that has already been fixed upstream.
>> $ env 'a|b=' dash -c 'set | grep a"."b'
>> a|b=''
>
> This I can reproduce though.
Meanwhile, I just tested the latest dash.git (commit f21016a12) and this
behavior is no longer present:
$ env 'a|b=' ./src/dash -c 'set | grep a"."b'
so it has also been fixed in the meantime. Sorry for not doing my
homework; nothing to fix here...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-30 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 15:01 'set' leaks garbage from environment Eric Blake
2014-09-30 15:14 ` Olof Johansson
2014-09-30 15:20 ` Eric Blake [this message]
2014-09-30 17:07 ` Harald van Dijk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542ACA54.50201@redhat.com \
--to=eblake@redhat.com \
--cc=dash@vger.kernel.org \
--cc=olof@ethup.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox