DASH Shell discussions
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: dash@vger.kernel.org
Subject: [PATCH] avoid clang warning about dead store to "size"
Date: Mon, 23 May 2011 10:31:43 +0200	[thread overview]
Message-ID: <878vtxrf68.fsf@rho.meyering.net> (raw)

I ran clang's scan-build on dash and it reported one nit:

ANALYZE: memalloc.c makestrspace
memalloc.c:276:9: warning: Value stored to 'size' during its initialization is never read
        size_t size = stackblocksize();
               ^      ~~~~~~~~~~~~~~~~


From f6fb674bab5afa22de4fcfb4a2debfa4d139c73c Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 23 May 2011 10:27:57 +0200
Subject: [PATCH] avoid clang warning about dead store to "size"

* src/memalloc.c (makestrspace): Remove dead store.

Signed-off-by: Jim Meyering <meyering@redhat.com>
---
 ChangeLog      |    3 +++
 src/memalloc.c |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 56c5c3f..8725b08 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,8 +1,11 @@
 2011-05-23  Jim Meyering  <meyering@redhat.com>

+	avoid clang warning about dead store to "size"
+	* src/memalloc.c (makestrspace): Remove dead store.
+
 	avoid gcc warning: variable 'oldstackp' set but not used
 	* src/memalloc.c (growstackblock): Remove declaration and set of
 	set-but-not-used variable.  Also remove a stray space-before-TAB.

 2011-03-15  Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/src/memalloc.c b/src/memalloc.c
index 9fea067..d8e4413 100644
--- a/src/memalloc.c
+++ b/src/memalloc.c
@@ -270,13 +270,13 @@ growstackstr(void)
  */

 char *
 makestrspace(size_t newlen, char *p)
 {
 	size_t len = p - stacknxt;
-	size_t size = stackblocksize();
+	size_t size;

 	for (;;) {
 		size_t nleft;

 		size = stackblocksize();
 		nleft = size - len;
--
1.7.5.2.1.g56b30

             reply	other threads:[~2011-05-23  8:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23  8:31 Jim Meyering [this message]
2011-07-08  8:16 ` [PATCH] avoid clang warning about dead store to "size" Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vtxrf68.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=dash@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox