DASH Shell discussions
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: dash@vger.kernel.org
Subject: [PATCH] avoid gcc warning: variable 'oldstackp' set but not used
Date: Mon, 23 May 2011 10:20:12 +0200	[thread overview]
Message-ID: <87ei3prfpf.fsf@rho.meyering.net> (raw)

Compiling with gcc-4.6.0, I noticed a new warning.
This fixes it:


From 6c4c5e33e9143946335e2adc952ea250e474926b Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 23 May 2011 10:18:27 +0200
Subject: [PATCH] avoid gcc warning: variable 'oldstackp' set but not used

* src/memalloc.c (growstackblock): Remove declaration and set of
set-but-not-used variable.  Also remove a stray space-before-TAB.

Signed-off-by: Jim Meyering <meyering@redhat.com>
---
 ChangeLog      |    6 ++++++
 src/memalloc.c |    4 +---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 50a8044..56c5c3f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-23  Jim Meyering  <meyering@redhat.com>
+
+	avoid gcc warning: variable 'oldstackp' set but not used
+	* src/memalloc.c (growstackblock): Remove declaration and set of
+	set-but-not-used variable.  Also remove a stray space-before-TAB.
+
 2011-03-15  Herbert Xu <herbert@gondor.apana.org.au>

 	* Fix clobbering of checkkwd.
diff --git a/src/memalloc.c b/src/memalloc.c
index e75e609..9fea067 100644
--- a/src/memalloc.c
+++ b/src/memalloc.c
@@ -206,20 +206,18 @@ growstackblock(void)
 {
 	size_t newlen;

- 	newlen = stacknleft * 2;
+	newlen = stacknleft * 2;
 	if (newlen < stacknleft)
 		sh_error("Out of space");
 	if (newlen < 128)
 		newlen += 128;

 	if (stacknxt == stackp->space && stackp != &stackbase) {
-		struct stack_block *oldstackp;
 		struct stack_block *sp;
 		struct stack_block *prevstackp;
 		size_t grosslen;

 		INTOFF;
-		oldstackp = stackp;
 		sp = stackp;
 		prevstackp = sp->prev;
 		grosslen = newlen + sizeof(struct stack_block) - MINSIZE;
--
1.7.5.2.1.g56b30

             reply	other threads:[~2011-05-23  8:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23  8:20 Jim Meyering [this message]
2011-07-08  8:12 ` [PATCH] avoid gcc warning: variable 'oldstackp' set but not used Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ei3prfpf.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=dash@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox