From: Herbert Xu <herbert@gondor.apana.org.au>
To: Martijn Dekker <martijn@inlv.org>
Cc: dash@vger.kernel.org
Subject: Re: [PATCH] Fix non-Linux build
Date: Sat, 18 May 2024 08:39:55 +0800 [thread overview]
Message-ID: <Zkf428Yvs_JMPmF2@gondor.apana.org.au> (raw)
In-Reply-To: <38a635d8-c129-4bcf-a274-af36d928263b@inlv.org>
Martijn Dekker <martijn@inlv.org> wrote:
> As of 509f5b0d, the build fails on Darwin/macOS, which does not have
> memfd_create(2). The build fails on redir.c because the fallback for
> memfd_create, which is defined in system.h, is not included. Presumably it is
> the same on other systems without memfd_create.
>
> diff --git a/src/redir.c b/src/redir.c
> index 2505d49..8a77a92 100644
> --- a/src/redir.c
> +++ b/src/redir.c
> @@ -57,6 +57,7 @@
> #include "memalloc.h"
> #include "error.h"
> #include "trap.h"
> +#include "system.h"
The patch was white-space damaged but I applied it by hand. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-05-18 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 21:02 [PATCH] Fix non-Linux build Martijn Dekker
2024-05-18 0:39 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zkf428Yvs_JMPmF2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=martijn@inlv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox