From: Herbert Xu <herbert@gondor.apana.org.au>
To: Harald van Dijk <harald@gigawatt.nl>
Cc: Aleksander Ushakov <aushakov@astralinux.ru>, dash@vger.kernel.org
Subject: Re: [PATCH] builtin: Fix argv overrun in aexpr and oexpr
Date: Thu, 28 Aug 2025 17:13:34 +0800 [thread overview]
Message-ID: <aLAdvpZDAFnlxx0a@gondor.apana.org.au> (raw)
In-Reply-To: <b948f6b0-a7a3-4441-90dc-d1dc968700ac@gigawatt.nl>
On Thu, Aug 28, 2025 at 10:12:05AM +0100, Harald van Dijk wrote:
>
> This patch fixes the buffer overrun but leaves the syntax error in the
> expression undetected, which is inconsistent with how dash treats other
> syntax errors in expressions, and inconsistent with how other shells treat
> missing operands to -a and -o.
It is what NetBSD does, which is where this code came from.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-08-28 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 11:30 [BUG] SEGV getop() src/bltin/test.c:171:7 Aleksander Ushakov
2025-07-31 12:30 ` Harald van Dijk
2025-08-28 7:36 ` [PATCH] builtin: Fix argv overrun in aexpr and oexpr Herbert Xu
2025-08-28 9:12 ` Harald van Dijk
2025-08-28 9:13 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLAdvpZDAFnlxx0a@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aushakov@astralinux.ru \
--cc=dash@vger.kernel.org \
--cc=harald@gigawatt.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox