From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Tue, 02 Jan 2018 13:56:27 +0000 Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline Message-Id: <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> List-Id: References: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org ----- Original Message ----- | ----- Original Message ----- | | Drop newline at the end of a message string when the printing function adds | | a newline. | | Hi Julia, | | NACK. | | As much as it's a pain when searching the source code for output strings, | this patch set goes against the accepted Linux coding style document. See: | | https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings | | Regards, | | Bob Peterson | | Hm. I guess I stand corrected. The document reads: "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." Still, the GFS2 and DLM code has a plethora of broken-up printk messages, and I don't like the thought of re-combining them all. Regards, Bob Peterson