DCCP protocol discussions
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 1/4][DCCP]: Introduce DCCPv6
Date: Sun, 11 Dec 2005 22:03:44 +0000	[thread overview]
Message-ID: <20051211220344.GA31017@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <39e6f6c70512110556r387a6a18q37baca095737e3e0@mail.gmail.com>

Arnaldo Carvalho de Melo <acme@ghostprotocols.net> :
[...]
index 0000000..23058dc
--- /dev/null
+++ b/net/dccp/ipv6.c
[...]
+static void dccp_v6_ctl_send_reset(struct sk_buff *rxskb)
+{
[...]
+	skb = alloc_skb(MAX_HEADER + sizeof(struct ipv6hdr) +
+			dccp_hdr_reset_len, GFP_ATOMIC);
+	if (skb = NULL) 
+	  	return;
[...]
+	/* sk = NULL, but it is safe for now. RST socket required. */
+	if (!ip6_dst_lookup(NULL, &skb->dst, &fl)) {
+
+		if ((xfrm_lookup(&skb->dst, &fl, NULL, 0)) < 0)
+			return;

skb leak ?

Same pattern in dccp_v6_ctl_send_ack/tcp_v6_send_{ack/reset}.

--
Ueimor

  reply	other threads:[~2005-12-11 22:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-11 13:56 [PATCH 1/4][DCCP]: Introduce DCCPv6 Arnaldo Carvalho de Melo
2005-12-11 22:03 ` Francois Romieu [this message]
2005-12-12  0:38 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051211220344.GA31017@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox