From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 1/1] DCCP: Stop logs being filled
Date: Tue, 24 Oct 2006 09:15:04 +0000 [thread overview]
Message-ID: <200610241015.04511@strip-the-willow> (raw)
In-Reply-To: <200610241732.30715.ian.mcdonald@jandi.co.nz>
| In my opinion this should go into 2.6.19 as bug and causes logs to be
| filled.
ACK - this is useful and I have found it to apply without problem. Minor quibble below.
| @@ -58,6 +58,9 @@ #define DCCP_RESOURCE_PROBE_INTERVAL ((u
|
| #define DCCP_RTO_MAX ((unsigned)(120 * HZ)) /* FIXME: using TCP value */
|
| +#define DCCP_XMIT_TIMEO 30000
| +/* Time in msecs for blocking transmit per packet */
All the #define comments in dccp.h are on the right, for consistency, maybe better:
#define DCCP_XMIT_TIMEO 30000 /* Time/ msecs for blocking transmit per packet */
(which is below the limit of 80 chars)
prev parent reply other threads:[~2006-10-24 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 4:32 [PATCH 1/1] DCCP: Stop logs being filled Ian McDonald
2006-10-24 9:15 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610241015.04511@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox