From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [BUG] DCCP performance stops on CCID3 at times
Date: Fri, 17 Nov 2006 18:26:23 +0000 [thread overview]
Message-ID: <200611171826.23545@strip-the-willow> (raw)
In-Reply-To: <200611161055.31036.ian.mcdonald@jandi.co.nz>
Quoting Ian McDonald:
| > I think that a warning message could bring in some light: maybe it is the case here that the RTT measurement is just
| > at rock bottom, always returns 0, and thus always stays at 1.
|
| It was just put in there to stop divide by zeros. It wasn't meant to
| be a proper fix.
I have added warning messages in latest patch.
| >
| > There is another thread which I think may be of relevance, incidentally again at the rx_packet_recv function:
| >
| > http://www.mail-archive.com/dccp%40vger.kernel.org/msg00118.html
| >
| This one has already been fixed. If you look at the code it's changed
| a fair bit since then. This was a bug which crippled my testing and I
| was glad to get sorted. I also removed some of the cc_val/window stuff
| at this point as I figured 80% working was better than 0% working as
| regards to congestion control...
I take your word for it - when looking yesterday, I noted that new functions and variable names
were used, but the structure seemed somewhat similar - but I am not so familiar with the CCID 3 code.
Will do some more code reading.
-- Gerrit
prev parent reply other threads:[~2006-11-17 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 21:55 [BUG] DCCP performance stops on CCID3 at times Ian McDonald
2006-11-16 17:45 ` Gerrit Renker
2006-11-17 0:33 ` Ian McDonald
2006-11-17 18:26 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611171826.23545@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox