DCCP protocol discussions
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCHv2] [DCCP]: Use higher timeout value for nofeedback timer
Date: Fri, 01 Dec 2006 13:14:26 +0000	[thread overview]
Message-ID: <200612011314.26835@strip-the-willow> (raw)

Hi Arnaldo,

many thanks for the detailed feedback - that has taught me some things I did not know.

I will reshape the patch with regards to comments. While at it, would like
to increase resolution up to units of 100ms, with a default value of 10 
corresponding to the TCP RTO value - as per earlier email by Mark Handley.
 

|  -                              "r_sample=%uus\n", dccp_role(sk), sk,
|  +                              "r_sample=%us\n", dccp_role(sk), sk,
|  
|  wrong, as r_sample is in microseconds, it comes from a timeval_delta,
|  that gets it from dccp_timestamp and the elapsed times, originally in
|  tenths of microsoeconds but multiplied by 10 to get back to
|  microseconds.
Disagree with the above, since r_sample is not changed and t_elapsed is
converted from units of 10*microseconds to microsecond by multiplication:

	r_sample = timeval_delta(&now, &packet->dccphtx_tstamp);
	t_elapsed = dp->dccps_options_received.dccpor_elapsed_time * 10;

I will put that into a different patch, as I am just going over previous ones
that I have sent and checking each one of them.

             reply	other threads:[~2006-12-01 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01 13:14 Gerrit Renker [this message]
2006-12-01 13:29 ` [PATCHv2] [DCCP]: Use higher timeout value for nofeedback timer Arnaldo Carvalho de Melo
2006-12-01 13:40 ` Gerrit Renker
2006-12-01 13:43 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200612011314.26835@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox