DCCP protocol discussions
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: [PATCH 0/8]: 2 Bug fixes, all earlier patches revised
Date: Fri, 01 Dec 2006 18:25:43 +0000	[thread overview]
Message-ID: <200612011825.43747@strip-the-willow> (raw)

I have been doing bug hunting almost all day, two bug fixes are enclosed, 
for the remainder I am willing to stick my head into the code next week
until the performance is up to a reasonable level and most of the known
bugs are ironed out. 

I went through the earlier patches and tossed out some material and re-arranged
the TFRC lookup stuff in a different way. I think it is now much easier to read.


Patch 1: Bug fix: sending rates were calculated before X_recv/p  were updated
Patch 2: Removes the `Illegal ACK received message' [it is harmless]
 

Patches 3..8 correspond to the earlier TFRC patches (much smaller now): 
     Ian I would appreciate if you could have a look at these. 
     I have put in effort to explain them clearer. While the performance still
     is bad, these are a step forward. In particular, the parameter checking is
     useful to have.  Should it be needed, I have documented all everything on
     http://www.erg.abdn.ac.uk/users/gerrit/dccp/tfrc_documentation/doc/


Patch 3: just adds documentation for the TFRC lookup table; no code change, but
         this provides the basis for all other patches (the formulas)

Patch 4: corrects a small error in the reverse lookup function; I 
         have now added a detailed explanation _why_ this is an error.

Patch 5: adds extensive parameter checking to the TFRC lookup routines.

Patch 6: wraps up the previous steps by simplifying the forward lookup. 
         It also defines a constant for the lowest possible resolution and
         adds a warning if p is greater than 0 and less than this threshold.

Patch 7: deprecates the use of TFRC_SMALLEST_P in ccid3.c. It is subsumed
         by the minimum threshold set in Patch 4. The use of TFRC_SMALLEST_P
         is dangerous, as it masks large errors for low values of p.
         The resolution error is exactly given by:
           (f(0.0001) - f(p))/f(p) * 100
         and for TFRC_SMALLEST_P = 0.00004 this is still a value of about 58%!
         It is better to observe the warning messages and generate a new table
         in case there are too many warnings.

Patch 8: adds bin-search which should speed up TFRC reverse-lookup a little

             reply	other threads:[~2006-12-01 18:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01 18:25 Gerrit Renker [this message]
2006-12-01 18:29 ` [PATCH 0/8]: 2 Bug fixes, all earlier patches revised Ian McDonald
2006-12-01 18:39 ` Gerrit Renker
2006-12-01 23:00 ` Ian McDonald
2006-12-02  1:33 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200612011825.43747@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox