From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 7/8]: Deprecate TFRC_SMALLEST_P
Date: Sat, 02 Dec 2006 12:54:45 +0000 [thread overview]
Message-ID: <200612021254.45708@strip-the-willow> (raw)
In-Reply-To: <200612011827.15505@strip-the-willow>
Quoting Ian McDonald:
| On 12/2/06, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
| > [DCCP]: Deprecate TFRC_SMALLEST_P
| >
| > Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
|
| Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
I would like to inform you that I have made a small change which
would otherwise cause erratic behaviour:
In ccid3_hc_tx_no_feedback_timer():
/* If (X_calc > 2 * X_recv)
X_recv = max(X_recv/2, s(2*t_mbi))
Else
X_recv = X_calc/4
- /* check also if p is zero -> x_calc is infinity? */
- if (hctx->ccid3hctx_p < TFRC_SMALLEST_P ||
- hctx->ccid3hctx_x_calc > 2 * hctx->ccid3hctx_x_recv)
hctx->ccid3hctx_x_recv = max_t(u32, hctx->ccid3hctx_x_recv / 2,
hctx->ccid3hctx_s / (2 * TFRC_T_MBI));
else
hctx->ccid3hctx_x_recv = hctx->ccid3hctx_x_calc / 4;
==> the previous replacement was:
+ if (hctx->ccid3hctx_x_calc > 2 * hctx->ccid3hctx_x_recv)
==> if p=0, the `else' case would be taken. But X_calc is then either a stale value or (at worst) 0
which would mean that the sender cuts off here. Therefore, I have done the following:
+ if (hctx->ccid3hctx_p = 0 ||
+ hctx->ccid3hctx_x_calc > 2 * hctx->ccid3hctx_x_recv)
==> In this way we avoid using a stale or zero value of X_calc
Keep the Acked-by?
next prev parent reply other threads:[~2006-12-02 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 18:27 [PATCH 7/8]: Deprecate TFRC_SMALLEST_P Gerrit Renker
2006-12-01 22:55 ` Ian McDonald
2006-12-02 12:54 ` Gerrit Renker [this message]
2006-12-02 18:38 ` Ian McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612021254.45708@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox