DCCP protocol discussions
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 4/5]: Rate-limit DCCP-Syncs
Date: Wed, 11 Apr 2007 09:35:04 +0000	[thread overview]
Message-ID: <200704111035.04456@strip-the-willow> (raw)
In-Reply-To: <200704091058.57313@strip-the-willow>

|  > The default value is set at compilation time when HZ is known. I used jiffies for the
|  > main reason to make this sysctl consistent with the other, similar, runtime variables
|  > which are also in units of jiffies (cf. Documentation/networking/ip-sysctl.txt):
|  > 
|  >  * inet_peer_minttl / inet_peer_maxttl / inet_peer_gc_mintime / inet_peer_gc_maxtime
|  
|  Actually these are in seconds, they use proc_dointvec_jiffies, which
|  takes seconds and converts to jiffies.
I haven't looked at the code - it may be that the information in ip-sysctl.txt is outdated.
  
<snip>
|  I agree with Ian that userspace interfaces should use fixed units that
|  don't depend on compile-time options.
|  
Ok,  will convert patch & Documentation to use milliseconds, and send an update later.

Thank you for the input.

  parent reply	other threads:[~2007-04-11  9:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-09  9:58 [PATCH 4/5]: Rate-limit DCCP-Syncs Gerrit Renker
2007-04-11  2:55 ` Ian McDonald
2007-04-11  9:13 ` Gerrit Renker
2007-04-11  9:22 ` Patrick McHardy
2007-04-11  9:35 ` Gerrit Renker [this message]
2007-06-20  9:56 ` Gerrit Renker
2007-07-01  4:01 ` Ian McDonald
2007-09-22 20:16 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704111035.04456@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox