DCCP protocol discussions
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 19/25]: Remove unused fields in packet history structure
Date: Fri, 13 Apr 2007 18:48:02 +0000	[thread overview]
Message-ID: <200704131948.03194@strip-the-willow> (raw)
In-Reply-To: <200703211845.41809@strip-the-willow>

Quoting Arnaldo Carvalho de Melo:
|  struct dccp_tx_hist_entry {
|          struct list_head           dccphtx_node;         /*     0    16 */
|          u64                        dccphtx_seqno;        /*    16     8 */
|          struct timeval             dccphtx_tstamp;       /*    24    16 */
|  }; /* size: 40, cachelines: 1 */
|     /* last cacheline: 40 bytes */
|  [acme@mica net-2.6.22]$
|  
|  I wonder if we could make this a single linked list, lemme see.. I
|  think so, and by doing that we get the struct down to 32 bytes, making
|  it cacheline friendly, and also simplify the operations, i.e. that
|  opencoded list operation would just go away, will leave this for
|  later, in a TODO file.
This is an excellent idea - I have just checked. It works, there is no sorting
and just LIFO order. 

Will you be working on this or would you like me to update this in terms of 
struct hlist_head?

      parent reply	other threads:[~2007-04-13 18:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21 18:45 [PATCH 19/25]: Remove unused fields in packet history structure Gerrit Renker
2007-03-26  3:20 ` Ian McDonald
2007-04-12 15:36 ` Arnaldo Carvalho de Melo
2007-04-13 18:48 ` Gerrit Renker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704131948.03194@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox