From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 2/5]: History access is redundant when sending feedback
Date: Mon, 25 Jun 2007 08:18:08 +0000 [thread overview]
Message-ID: <200706250918.08630@strip-the-willow> (raw)
In-Reply-To: <200706141005.07993@strip-the-willow>
Quoting Ian McDonald:
| > This patch
| > 1. removes redundant use of packet history for sending feedback
| > (data packet is no longer `found', just referenced);
| > 2. which obsoletes function dccp_rx_hist_find_data_packet - removed;
| > 3. removes an irrelevant state `TERM' (feedback is then not sent);
| > 4. removes redundant variable `last_ack' (duplicates `last_feedback');
| > 5. converts rx_send_feedback() to use the newer timeofday interface;
| > 6. simplify the computation of p/p_inv (see note below).
| >
| Great - making code much simpler - makes it easier for people like me
| to understand!
... and people like me too. I think it is good to keep code as simple as possible,
to better see the interactions. Thank you for really going through the patches
individually, I'd especially appreciate input for further simplifications. After
talking to Arnaldo recently, there is at least one further patch to further reduce
- removing redundant initialisations with `0' in tx_init/rx_init.
prev parent reply other threads:[~2007-06-25 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 9:05 [PATCH 2/5]: History access is redundant when sending feedback Gerrit Renker
2007-06-24 21:27 ` Ian McDonald
2007-06-25 8:18 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706250918.08630@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox