Re: [PATCH v2 4/5]: Rate-limit DCCP-Syncs

[Gerrit Renker <gerrit@erg.abdn.ac.uk>]

|  > +/* rate-limit for syncs in reply to sequence-invalid packets; RFC 4340, 7.5.4 */
|  > +int sysctl_dccp_sync_ratelimit       __read_mostly = HZ / 8;
|  
|  Why the extra spaces/tabs before __read_mostly? 
This is for consistency with the sysctls below, the whole paragraph looks like this:

/* the maximum queue length for tx in packets. 0 is no limit */
int sysctl_dccp_tx_qlen         __read_mostly = 5;

/* sysctl variables governing numbers of retransmission attempts */
int sysctl_dccp_request_retries __read_mostly = TCP_SYN_RETRIES;
int sysctl_dccp_retries1        __read_mostly = TCP_RETR1;
int sysctl_dccp_retries2        __read_mostly = TCP_RETR2;

/* rate-limit for syncs in reply to sequence-invalid packets; RFC 4340, 7.5.4 */
int sysctl_dccp_sync_ratelimit  __read_mostly = HZ / 8;

Sigh - I just wanted to be `neat', but each maintainer has a different conception of that :)

|  One more: 
|  In linux networking code what has been the most accepted form for
|  multiline expressions is:
|  
|                  if (time_after(now, (dp->dccps_rate_last +
|                                       sysctl_dccp_sync_ratelimit))) {
|  
|  Either form produces the same code, but as the later is what I, David
|  and others are most confortable with and have been using for quite a
|  while, 
Please excuse my ignorance: that was simply something I didn't know, and thus it is good that
it is on the list, so that others can also adapt this. Thanks for explaining.

It is _very_ important since in CCID3/CCID4 variable names are all very long (the drafts are
also long), and lots of calculations.

Will fix that and put the result in the tree.